Add locale to target_lang_name in wmt24pp prepare.py - #1980
Merged
Conversation
… current nemo-skills implementation. Verify user input lang codes. Signed-off-by: Brian Thompson <3534106+thompsonb@users.noreply.github.com>
bxyu-nvidia
approved these changes
Jul 16, 2026
OlegSudakov
pushed a commit
to OlegSudakov/Gym
that referenced
this pull request
Aug 7, 2026
Adds locale to target_lang_name in wmt24pp prepare.py, consistent with current nemo-skills implementation (https://github.com/NVIDIA-NeMo/Skills/blob/7b3fb04e131b3a31ec00d28b65ff7eea776b5249/nemo_skills/dataset/wmt24pp/prepare.py#L33). Also fixes issue of non-default languages crashing because they were not in _LANG_DISPLAY_NAMES. Added checks that user supplied languages are actually in wmt24pp. Languages codes and names are hardcoded to avoid network calls and dependence on additional packages - this should be fine as wmt24pp will not change languages. Signed-off-by: Brian Thompson <3534106+thompsonb@users.noreply.github.com> Co-authored-by: Brian Thompson <3534106+thompsonb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds locale to target_lang_name in wmt24pp prepare.py, consistent with current nemo-skills implementation (https://github.com/NVIDIA-NeMo/Skills/blob/7b3fb04e131b3a31ec00d28b65ff7eea776b5249/nemo_skills/dataset/wmt24pp/prepare.py#L33). Also fixes issue of non-default languages crashing because they were not in _LANG_DISPLAY_NAMES. Added checks that user supplied languages are actually in wmt24pp. Languages codes and names are hardcoded to avoid network calls and dependence on additional packages - this should be fine as wmt24pp will not change languages.