fix(vllm): handle null request metadata - #2139
Merged
Merged
Conversation
Signed-off-by: Anish Mahishi <amahishi@nvidia.com>
bxyu-nvidia
approved these changes
Jul 24, 2026
tdene
added a commit
that referenced
this pull request
Jul 30, 2026
OlegSudakov
pushed a commit
to OlegSudakov/Gym
that referenced
this pull request
Aug 7, 2026
Treat explicit metadata=null the same as omitted metadata when processing per-request chat-template and extra-body overrides. Add regression coverage for Responses API requests containing null metadata. Signed-off-by: Anish Mahishi <amahishi@nvidia.com>
OlegSudakov
pushed a commit
to OlegSudakov/Gym
that referenced
this pull request
Aug 7, 2026
Follow-up to NVIDIA-NeMo#2139 and NVIDIA-NeMo#1180 Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat explicit metadata=null the same as omitted metadata when processing per-request chat-template and extra-body overrides.
Add regression coverage for Responses API requests containing null metadata.