ci: bump claude review workflow to FW-CI-templates v1.8.4 - #2167
Merged
Conversation
v1.7.0 completed successfully but never posted a review comment — Claude generated the verdict as final text without calling gh pr comment. v1.8.4 (FW-CI-templates #523/#525) adds an explicit publish contract that requires Claude to post a top-level comment on every run. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Kajal Jain <kajalj@nvidia.com>
cmunley1
previously approved these changes
Jul 28, 2026
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Kajal Jain <kajalj@nvidia.com>
kajalj22
enabled auto-merge (squash)
July 28, 2026 18:49
chtruong814
approved these changes
Jul 28, 2026
OlegSudakov
pushed a commit
to OlegSudakov/Gym
that referenced
this pull request
Aug 7, 2026
…o#2167) ## Summary - Bumps `/claude review` workflow from FW-CI-templates `v1.7.0` → `v1.8.4` - `v1.7.0` had a bug where Claude generated the review but never posted it to the PR (see NVIDIA-NeMo#2158 — workflow reported success, no comment appeared) - Fixed upstream in FW-CI-templates by [fix: allow Claude review top-level PR comments (NVIDIA-NeMo#523)](NVIDIA-NeMo/FW-CI-templates#523) and [fix: Claude review comment identity and publish contract (NVIDIA-NeMo#525)](NVIDIA-NeMo/FW-CI-templates#525) ## Test plan - [ ] Trigger `/claude review` on a test PR and confirm a comment is posted 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Signed-off-by: Kajal Jain <kajalj@nvidia.com> Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/claude reviewworkflow from FW-CI-templatesv1.7.0→v1.8.4v1.7.0had a bug where Claude generated the review but never posted it to the PR (see feat: add SECQUE and FinanceBench benchmarks, remove duplicate finance_sec_search environment #2158 — workflow reported success, no comment appeared)🤖 Generated with Claude Code