Skip to content

ci: bump claude review workflow to FW-CI-templates v1.8.4 - #2167

Merged
kajalj22 merged 2 commits into
mainfrom
bump-claude-review-v1.8.4
Jul 28, 2026
Merged

ci: bump claude review workflow to FW-CI-templates v1.8.4#2167
kajalj22 merged 2 commits into
mainfrom
bump-claude-review-v1.8.4

Conversation

@kajalj22

@kajalj22 kajalj22 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary

🤖 Generated with Claude Code

v1.7.0 completed successfully but never posted a review comment — Claude
generated the verdict as final text without calling gh pr comment. v1.8.4
(FW-CI-templates #523/#525) adds an explicit publish contract that requires
Claude to post a top-level comment on every run.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Kajal Jain <kajalj@nvidia.com>
@kajalj22
kajalj22 requested a review from a team as a code owner July 28, 2026 18:37
@copy-pr-bot

copy-pr-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

cmunley1
cmunley1 previously approved these changes Jul 28, 2026
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Kajal Jain <kajalj@nvidia.com>
@kajalj22
kajalj22 enabled auto-merge (squash) July 28, 2026 18:49
@kajalj22
kajalj22 merged commit 328511e into main Jul 28, 2026
14 checks passed
@kajalj22
kajalj22 deleted the bump-claude-review-v1.8.4 branch July 28, 2026 18:50
OlegSudakov pushed a commit to OlegSudakov/Gym that referenced this pull request Aug 7, 2026
…o#2167)

## Summary

- Bumps `/claude review` workflow from FW-CI-templates `v1.7.0` →
`v1.8.4`
- `v1.7.0` had a bug where Claude generated the review but never posted
it to the PR (see NVIDIA-NeMo#2158 — workflow reported success, no comment
appeared)
- Fixed upstream in FW-CI-templates by [fix: allow Claude review
top-level PR comments
(NVIDIA-NeMo#523)](NVIDIA-NeMo/FW-CI-templates#523) and
[fix: Claude review comment identity and publish contract
(NVIDIA-NeMo#525)](NVIDIA-NeMo/FW-CI-templates#525)

## Test plan

- [ ] Trigger `/claude review` on a test PR and confirm a comment is
posted

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Signed-off-by: Kajal Jain <kajalj@nvidia.com>
Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants