feat(trace): add explicit span emission helpers - #49
Merged
Conversation
Member
|
/ok to test 1828ae4 |
ahmadki
previously approved these changes
Sep 3, 2026
rhewett-nv
force-pushed
the
rhewett/pr2-span-utilities
branch
from
September 3, 2026 18:31
1828ae4 to
96494a2
Compare
rhewett-nv
force-pushed
the
rhewett/pr2-span-utilities
branch
from
September 3, 2026 18:47
96494a2 to
0890293
Compare
rhewett-nv
force-pushed
the
rhewett/pr2-span-utilities
branch
2 times, most recently
from
September 3, 2026 19:28
3b89e45 to
401774f
Compare
rhewett-nv
force-pushed
the
rhewett/pr2-span-utilities
branch
from
September 4, 2026 00:30
401774f to
66d2c09
Compare
Member
|
/ok to test 66d2c09 |
ahmadki
approved these changes
Sep 4, 2026
Signed-off-by: Russell Hewett <rhewett@nvidia.com>
ahmadki
force-pushed
the
rhewett/pr2-span-utilities
branch
from
September 4, 2026 14:17
66d2c09 to
4a9ddcc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds explicit timestamp span utilities for emitting completed spans and deriving Linux process start time without expanding the top-level Lens API.
Issues
N/A
Usage
Before your PR is "Ready for review"
Pre checks:
git commit -s) per the DCO.tests/for any behavior change.pytestandpre-commit run --all-fileslocally; both pass.docs/andREADME.mdwhere behavior, configuration, or public API changed._fallbacks.pyfiles in Megatron-LM / RL / Gym.Additional information
Validation on
pr2-span-utilities:../.venv/bin/pre-commit run --all-files: passedPYTHONPATH=src ../.venv/bin/python -m pytest -q:247 passed, 7 warnings../.venv/bin/python -m compileall -q src tests: passednpm --prefix docs/fern run check: passed with0 errors; one warning because the unauthenticated redirects check is skipped withoutfern login/FERN_TOKENNotes:
1828ae4 feat(trace): add explicit span emission helpers.src/nemo/lens/span_utilities.pyandtests/test_span_utilities.py.nemo.lensexports.opentelemetry.sdkimports undersrc/; SDK usage is test-only.