Skip to content

ci: skip sglang build and tests for external contributors#2532

Merged
chtruong814 merged 2 commits into
mainfrom
kajalj/skip-sglang-external
May 20, 2026
Merged

ci: skip sglang build and tests for external contributors#2532
chtruong814 merged 2 commits into
mainfrom
kajalj/skip-sglang-external

Conversation

@kajalj22

@kajalj22 kajalj22 commented May 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Temporarily skip sglang tests when sglang is not installed, so the test scripts handle missing sglang gracefully instead of failing
  • Disable sglang build for external contributors (non-NVIDIA SSO members) until the external contributor Lfast flow can be fixed

Changes

  • .github/workflows/cicd-main.yml: Pass SKIP_SGLANG_BUILD=1 to the container build when org-member-pre-flight.outputs.is_member \!= 'true'
  • tests/unit/L0_Unit_Tests_{Generation,Other,Policy}.sh: Guard sglang test blocks with python -c "import sglang" check — skip gracefully if sglang is not available
  • tests/functional/L1_Functional_Tests_GPU.sh: Same guard for the grpo_sglang.sh functional test

Test plan

  • Verify NVIDIA member PRs still build sglang and run sglang tests (no change in behavior)
  • Verify external contributor PRs skip sglang build and gracefully skip sglang tests

🤖 Generated with Claude Code

kajalj22 and others added 2 commits May 19, 2026 12:37
External contributors don't need sglang and its build is slow due to
CMake compilation. Pass SKIP_SGLANG_BUILD=1 to the container build when
the PR author is not an NVIDIA SSO member.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Kajal Jain <kajalj@nvidia.com>
Guard sglang test blocks with a python import check so they are
gracefully skipped in containers built with SKIP_SGLANG_BUILD=1
(external contributor builds).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Kajal Jain <kajalj@nvidia.com>
@kajalj22
kajalj22 requested a review from a team as a code owner May 19, 2026 17:41
@copy-pr-bot

copy-pr-bot Bot commented May 19, 2026

Copy link
Copy Markdown

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the CI Relating to CI label May 19, 2026
@kajalj22

Copy link
Copy Markdown
Contributor Author

/ok to test c45e889

@kajalj22 kajalj22 added the CI:Lfast Runs a fast test suite and re-use nightly `main` container (but sync dependencies to PRs version) label May 20, 2026
@kajalj22 kajalj22 added CI:L1 Run doctests, unit tests, and functional tests and removed CI:Lfast Runs a fast test suite and re-use nightly `main` container (but sync dependencies to PRs version) labels May 20, 2026
@chtruong814
chtruong814 merged commit 79a6290 into main May 20, 2026
43 of 44 checks passed
@chtruong814
chtruong814 deleted the kajalj/skip-sglang-external branch May 20, 2026 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:L1 Run doctests, unit tests, and functional tests CI Relating to CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants