chore: move contributor-facing skills to .agents/contributor-skills/#2561
Merged
Conversation
Separate contributor-facing skills (testing, linting, CI/CD, review, etc.) from customer-facing ones (launch-nemo-rl, auto-research, brev-etiquette, docs). The 10 contributor skills now live in .agents/contributor-skills/ while the 4 customer-facing skills remain in skills/. Replace the single .claude/skills symlink with per-skill symlinks so Claude Code's .claude/skills/*/SKILL.md glob continues to discover all 14 skills from a unified path. Remove the now-stale .agents/skills symlink. Update AGENTS.md (which CLAUDE.md symlinks to) to document the two-location layout. Signed-off-by: Terry Kong <terryk@nvidia.com>
terrykong
commented
May 24, 2026
terrykong
left a comment
terrykong
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review: PR #2561 — chore: move contributor-facing skills to .agents/contributor-skills/
Clean organizational refactor. Verified locally:
- All 14 per-skill symlinks under
.claude/skills/resolve correctly and each target contains aSKILL.md ls .claude/skills/*/SKILL.mddiscovers all 14 skills (4 customer-facing via../../skills/, 10 contributor-facing via../../.agents/contributor-skills/)- Old symlinks (
.agents/skills,.claude/skillsdirectory symlink) properly removed review-pr/advanced.mdmoved alongside itsSKILL.md- No stale references to the old
skills/<moved-skill>paths found in any.md,.json,.yaml, or.tomlfiles - AGENTS.md accurately documents the two-location layout
No issues found.
Generated by Claude Code
Collaborator
Author
|
/claude review |
yuki-97
approved these changes
May 25, 2026
Contributor
|
/ok to test 4d81df5 |
yuki-97
enabled auto-merge (squash)
May 25, 2026 05:49
yfw
pushed a commit
that referenced
this pull request
May 27, 2026
…2561) Signed-off-by: Terry Kong <terryk@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills/to.agents/contributor-skills/skills/.claude/skills → ../skillssymlink with 14 per-skill symlinks so Claude Code's.claude/skills/*/SKILL.mdglob continues to discover all skills from a unified path.agents/skillssymlinkNo CI, review-pr, or settings.json changes were needed — CI doesn't reference skills, and the review-pr skill's
.claude/skills/*/SKILL.mdglob still resolves through the per-skill symlinks.Test plan
ls .claude/skills/*/SKILL.mdlists all 14 SKILL.md filesskills/has exactly 4 directories (auto-research, brev-etiquette, docs, launch-nemo-rl).agents/contributor-skills/has exactly 10 directories/review-pr) and confirm it loads correctlylaunch-nemo-rl) and confirm it loads correctly🤖 Generated with Claude Code