Skip to content

chore: bump TQ to v0.19 - #3423

Open
macandro96 wants to merge 5 commits into
mainfrom
amahishi/tq-v0.1.9-bump
Open

chore: bump TQ to v0.19#3423
macandro96 wants to merge 5 commits into
mainfrom
amahishi/tq-v0.1.9-bump

Conversation

@macandro96

@macandro96 macandro96 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

  1. Bumps TQ to v0.19 to enable checkpointing (Ref here)
  2. Fixes for TQ v0.1.9 changing Mooncake reads: uniform rows were returned as nested tensors

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@macandro96
macandro96 requested review from a team as code owners July 30, 2026 02:17
@copy-pr-bot

copy-pr-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@macandro96 macandro96 added the CI:Lfast Runs a fast test suite and re-use nightly `main` container (but sync dependencies to PRs version) label Jul 30, 2026
@macandro96

Copy link
Copy Markdown
Contributor Author

/ok to test 97f1b6e

@macandro96
macandro96 force-pushed the amahishi/tq-v0.1.9-bump branch from 70fcd8d to 827ca05 Compare July 31, 2026 18:59
Signed-off-by: Anish Mahishi <amahishi@nvidia.com>
Signed-off-by: Anish Mahishi <amahishi@nvidia.com>
Track Mooncake 1D promotion in durable TQ metadata so genuine singleton token columns retain their rank. Remove the obsolete pre-0.1.9 storage import fallback and add focused regression coverage.

Signed-off-by: Anish Mahishi <amahishi@nvidia.com>
Densify uniform nested reads for the simple backend without applying Mooncake's singleton squeeze. Make wire-field typing explicit, test invalid shape provenance, and warn when either TQ actor runtime patch is unavailable.

Signed-off-by: Anish Mahishi <amahishi@nvidia.com>
TransferQueue v0.1.9 dropped its numpy<2.0.0 pin, so the override's
original justification no longer applies. The constraint it actually
bypasses now is tensorrt-llm's numpy>=2.0.0,<2.4.

Signed-off-by: Anish Mahishi <amahishi@nvidia.com>
@macandro96
macandro96 force-pushed the amahishi/tq-v0.1.9-bump branch from 827ca05 to 3f1e250 Compare July 31, 2026 20:18
@macandro96 macandro96 added CI:L1 Run doctests, unit tests, and functional tests and removed CI:Lfast Runs a fast test suite and re-use nightly `main` container (but sync dependencies to PRs version) labels Jul 31, 2026
@macandro96

Copy link
Copy Markdown
Contributor Author

/ok to test 3f1e250

michal2409 added a commit to michal2409/RL that referenced this pull request Aug 2, 2026
max(train/critic/loss) lands at 6.68-7.00 in CI for unrelated PRs
(NVIDIA-NeMo#3401, NVIDIA-NeMo#3404, NVIDIA-NeMo#3423) since the vLLM 0.25.1 bump; the same critic-side
drift is already tracked in NVIDIA-NeMo#3412. Placeholder bump, like the grad_norm
bound raised in NVIDIA-NeMo#3280.

Signed-off-by: Michal Futrega <mfutrega@nvidia.com>
michal2409 added a commit to michal2409/RL that referenced this pull request Aug 2, 2026
max(train/critic/loss) lands at 6.68-7.00 in CI for unrelated PRs
(NVIDIA-NeMo#3401, NVIDIA-NeMo#3404, NVIDIA-NeMo#3423) since the vLLM 0.25.1 bump; the same critic-side
drift is already tracked in NVIDIA-NeMo#3412. Placeholder bump, like the grad_norm
bound raised in NVIDIA-NeMo#3280.

Signed-off-by: Michal Futrega <mfutrega@nvidia.com>
@ZhiyuLi-Nvidia

Copy link
Copy Markdown
Contributor

Thank you macandro96 could you pick up 2 runs for verification with tq bump up?
one for TQ Simple and one for TQ Mooncake?

@macandro96

Copy link
Copy Markdown
Contributor Author

Thank you macandro96 could you pick up 2 runs for verification with tq bump up? one for TQ Simple and one for TQ Mooncake?

@ZhiyuLi-Nvidia Yep - i believe its part of the CI which seems to have passed?

  1. For grpo_dp_simple.sh : Logs here
  2. For grpo_dp_mooncake.sh: Logs here

Let me know if you were referring to a different run or want me to do something differently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:L1 Run doctests, unit tests, and functional tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants