fix(libsy): in-flight algo count metric - #576
Conversation
|
Signed-off-by: Greg Clark <grclark@nvidia.com>
Signed-off-by: Greg Clark <grclark@nvidia.com>
5651afa to
8a1ffff
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe change adds an RAII guard for algorithm in-flight metrics. Tests cover unresolved routing calls, completed runs, and abandoned runs. The metrics reference documents the new gauge and triage guidance. ChangesAlgorithm observability
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This PR adds an in-flight algorithm gauge and documentation/tests without any identified merge-blocking risk; it is merge-ready after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 81.82% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 2 files. (1 skipped: 1 unsupported.) Comment |
What
Adds
switchyard_algorithms_in_flight{algorithm}gauge.Why
Helps monitor load and stuck algorithms.
Closes
SWITCH-1238
Summary by CodeRabbit
Observability
Documentation