ci: lock Rust checks and test prefill feature - #676
Conversation
Signed-off-by: Alex Fournier <afournier@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 8 remain after this review. WalkthroughThe Rust CI workflow now uses locked dependencies for workspace checks and adds Clippy and test coverage for the ChangesRust CI validation
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change strengthens Rust CI validation without altering runtime behavior or public APIs. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
A rabbit checks the Rusty gate Comment |
|
@grahamking for review |
What
--locked.prefill-routerintegration.Why
The current Rust job does not fail when the Cargo manifests and committed lockfile disagree.
Cargo documents
--lockedas requiring the dependency versions recorded inCargo.lockto remain unchanged. It exits with an error if the lockfile is missing or dependency resolution would update it.It also tests the standalone
prefill-routerworkspace crate without enabling the optional integration inswitchyard-runneror the feature forwarded byswitchyard-server.The existing default checks stay in place because they compile the feature-disabled runner path. The two new steps cover the enabled path without rerunning every workspace test with
--all-features.Notes for reviewers
This changes one workflow file (
+6/-2). It does not change runtime behavior, public APIs, dependencies, packages, or release workflows.How tested
cargo fmt --all --checkcargo clippy --workspace --all-targets --locked -- -D warningscargo clippy -p switchyard-server --all-targets --features prefill-router --locked -- -D warningscargo test --workspace --lockedcargo test -p switchyard-runner --features prefill-router --lockedgit diff --checkNo live provider test was run because this only changes the Cargo commands used by CI.