feat(studio): when model fileset created, land on detail page

[nv-odrulea]

Summary by CodeRabbit

• Bug Fixes

  • Post-creation navigation now sends users to the correct model details page and tab based on storage mode (local vs external) instead of the previous fileset route.

• New Features

  • Files tab now displays a fileset description above the README when a description is present.

• Tests

  • Updated navigation test to assert the new model-details tab behavior.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 107a0dac-0db1-46b0-aa1b-1ba436f5946e

📥 Commits

Reviewing files that changed from the base of the PR and between f2e1413 and b2fb861.

📒 Files selected for processing (1)

• web/packages/studio/src/routes/ModelDetailRoute/ModelCardTab/index.tsx

---

📝 Walkthrough

Walkthrough

FilesetCreateModal now navigates to the model detail Files or External tab after creating a model fileset; ModelCardTab renders a fileset description above the README; tests updated to expect the model detail Files tab route.

Changes

Model fileset creation navigation and display

Layer / File(s)	Summary
Model detail navigation routing web/packages/studio/src/components/FilesetCreateModal/index.tsx	Imports add ModelDetailTab/getModelDetailRoute. Post-create navigation for model-purpose filesets now uses getModelDetailRoute, selecting Files for local or External for external storage; navigation comment updated.
Model Files tab UI: description + README web/packages/studio/src/routes/ModelDetailRoute/ModelCardTab/index.tsx	Adds Stack to imports; wraps ReadmeBody in a Stack and conditionally renders fileset.description as Text above the README.
Navigation test assertion web/packages/studio/src/components/FilesetCreateModal/index.spec.tsx	Test renamed/updated to assert navigation to model detail Files tab route (/workspaces/default/models/<name>?tab=files) instead of the fileset side-panel route.

Possibly related PRs

• NVIDIA-NeMo/nemo-platform#122: Related changes updating post-fileset-creation navigation to model detail Files view via getModelDetailRoute.
• NVIDIA-NeMo/nemo-platform#120: Direct predecessor unifying FilesetCreateModal implementation and establishing navigation behavior assertions.

Suggested reviewers

• htolentino-nvidia
• aray12

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	Title accurately describes the main change: redirecting users to the model detail page after creating a fileset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch od/create-fileset-land-on-model-detail

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

web/packages/studio/src/components/FilesetCreateModal/index.spec.tsx (1)

263-290: ⚡ Quick win

Missing coverage for Model + External → Card tab.

The new isExternal ? ModelDetailTab.Card : Files branch only tests the Local path. The External (?tab=card) branch is untested. Consider adding a case mirroring the dataset external flow.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@web/packages/studio/src/components/FilesetCreateModal/index.spec.tsx` around
lines 263 - 290, Add a new test case mirroring the Local model test but covering
the External branch: render FilesetCreateModal with
purpose={FilesetPurpose.model}, set mockMutate.mockResolvedValue to return the
fileset with name 'mymodel' and isExternal/is_external true (similar to how
dataset external flow is mocked), simulate typing the name and clicking the
create button, then assert navigate was called with a URL containing
'/workspaces/default/models/mymodel?tab=card' to verify the Model+External →
Card tab branch is covered (use the same helpers: mockUseNavigate, mockMutate,
userEvent, and expect.stringContaining to locate the URL).

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@web/packages/studio/src/components/FilesetCreateModal/index.spec.tsx`:
- Around line 263-290: Add a new test case mirroring the Local model test but
covering the External branch: render FilesetCreateModal with
purpose={FilesetPurpose.model}, set mockMutate.mockResolvedValue to return the
fileset with name 'mymodel' and isExternal/is_external true (similar to how
dataset external flow is mocked), simulate typing the name and clicking the
create button, then assert navigate was called with a URL containing
'/workspaces/default/models/mymodel?tab=card' to verify the Model+External →
Card tab branch is covered (use the same helpers: mockUseNavigate, mockMutate,
userEvent, and expect.stringContaining to locate the URL).

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6ee71d01-23cc-46f8-bc48-70dbbcb00006

📥 Commits

Reviewing files that changed from the base of the PR and between a373258 and f2e1413.

📒 Files selected for processing (2)

• web/packages/studio/src/components/FilesetCreateModal/index.spec.tsx
• web/packages/studio/src/components/FilesetCreateModal/index.tsx

[github-actions]

Suite	Lines Covered	Line Rate	Branch Rate
Unit Tests	18437/24420	75.5%	62.0%
Integration Tests	11867/23197	51.2%	26.4%