Skip to content

feat(studio): Dataset card#166

Merged
steramae-nvidia merged 3 commits into
mainfrom
steramae/astd-170-filesets-external-dataset-detail-card
Jun 4, 2026
Merged

feat(studio): Dataset card#166
steramae-nvidia merged 3 commits into
mainfrom
steramae/astd-170-filesets-external-dataset-detail-card

Conversation

@steramae-nvidia
Copy link
Copy Markdown
Contributor

@steramae-nvidia steramae-nvidia commented Jun 3, 2026

Screenshot 2026-06-03 at 1 53 19 PM

Consolidate the Model and Dataset tab components for fileset details route behind FF

Summary by CodeRabbit

  • New Features

    • Unified Fileset detail page that consolidates dataset and model detail views into one purpose-aware interface.
  • Improvements

    • Consistent "Card" and "Files" tabs with URL-driven tab selection and file-preview behavior.
    • Navigation now directs to a single fileset detail destination after creation.
    • UI copy updates and clearer error messages for file loading.

Signed-off-by: Sean Teramae <steramae@nvidia.com>
@steramae-nvidia steramae-nvidia requested review from a team as code owners June 3, 2026 20:58
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 3, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f7eb1e30-1481-4d56-8f37-b6806ed4bc3a

📥 Commits

Reviewing files that changed from the base of the PR and between 2f69ac4 and 420c7b6.

📒 Files selected for processing (1)
  • web/packages/studio/src/components/FilesetCreateModal/index.spec.tsx

📝 Walkthrough

Walkthrough

Consolidates dataset/model detail pages into a single purpose-aware FilesetDetailRoute, replaces dataset/model route params/helpers with fileset variants, refactors FilesTab and card/metadata components to use fileset props, and updates navigation and tests to use filesetName/filesetDetail.

Changes

Fileset Detail Route Consolidation

Layer / File(s) Summary
Route constants and helpers
web/packages/studio/src/constants/routes.ts, web/packages/studio/src/routes/FilesetDetailRoute/constants.ts, web/packages/studio/src/routes/utils.ts
ROUTE_PARAMS replaces datasetName with filesetName; new filesetDetail route added to ROUTES; FilesetDetailTab enum (card/files) and type-guard introduced; old getDatasetDetailRoute and getModelDetailRoute helpers removed and replaced with getFilesetDetailRoute.
FilesetDetailRoute implementation
web/packages/studio/src/routes/FilesetDetailRoute/index.tsx, web/packages/studio/src/routes/FilesetDetailRoute/index.spec.tsx
Main route component fetches fileset, derives UI text and default tab from fileset.purpose, wires tab selection to ?tab= query param, and renders FilesetCard + FilesTab with fileset-oriented props. Tests verify tab switching, query-param preview behavior, and purpose-dependent card labeling.
FilesetCard component (card tab)
web/packages/studio/src/routes/FilesetDetailRoute/FilesetCard/index.tsx, web/packages/studio/src/routes/FilesetDetailRoute/FilesetMetadataPanel/index.tsx, web/packages/studio/src/routes/FilesetDetailRoute/FilesetCard/ReadmeBody.tsx
Renamed from ModelCardTab to FilesetCard; filesetName prop replaces modelName; FilesetMetadataPanel replaces ModelMetadataPanel; error/missing-README messages generalized from model-specific to fileset-wide copy.
FilesTab refactoring
web/packages/studio/src/routes/FilesetDetailRoute/FilesTab/index.tsx, web/packages/studio/src/routes/FilesetDetailRoute/DatasetSchemaEditor/index.tsx
Converted to presentational component receiving fileset, files, isFilesError, isFilesFetching from parent instead of self-fetching. Schema editor panel gating now uses fileset.purpose === FilesetPurpose.dataset. File explorer/preview logic retains query-param control; test IDs updated.
Navigation and route integration
web/packages/studio/src/components/FilesetCreateModal/index.tsx, web/packages/studio/src/routes/FilesetListRoute/index.tsx, web/packages/studio/src/routes/FilesetNewRoute/index.tsx, web/packages/studio/src/routes/index.tsx
FilesetCreateModal, FilesetListRoute, and FilesetNewRoute now use getFilesetDetailRoute for all post-action navigation instead of dataset/model-specific routes. FilesetDetailRoute lazy-loaded in route index with unified error panel and suspense fallback.
Cleanup and test updates
web/packages/studio/src/routes/ModelDetailRoute/FilesTab/index.tsx, web/packages/studio/src/routes/ModelDetailRoute/constants.ts, web/packages/studio/src/routes/FilesetDetailRoute/FilesetMetadataPanel/utils.spec.ts, web/packages/studio/src/tests/title-change.spec.tsx
Deleted ModelDetailRoute/FilesTab and ModelDetailRoute/constants; updated test imports to use fileset route modules; test params switched from datasetName to filesetName.

Possible related PRs:

Suggested reviewers:

  • htolentino-nvidia
  • nv-odrulea
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive Title 'Dataset card' is vague and doesn't clearly convey the main architectural change—consolidation of Dataset/Model detail routes into a unified FilesetDetailRoute. Use a more specific title like 'refactor(studio): Consolidate dataset and model detail routes into FilesetDetailRoute' or 'feat(studio): Unified FilesetDetailRoute for dataset and model cards'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch steramae/astd-170-filesets-external-dataset-detail-card

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

Suite Lines Covered Line Rate Branch Rate
Unit Tests 18655/24692 75.5% 62.0%
Integration Tests 11978/23469 51.0% 26.2%

Signed-off-by: Sean Teramae <steramae@nvidia.com>
…detail-card

Signed-off-by: Sean Teramae <steramae@nvidia.com>
@steramae-nvidia steramae-nvidia added this pull request to the merge queue Jun 4, 2026
Merged via the queue into main with commit 8e1ef2e Jun 4, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants