Skip to content

fix(studio): Guardrails types#285

Merged
steramae-nvidia merged 2 commits into
mainfrom
steramae/rails-types
Jun 11, 2026
Merged

fix(studio): Guardrails types#285
steramae-nvidia merged 2 commits into
mainfrom
steramae/rails-types

Conversation

@steramae-nvidia

@steramae-nvidia steramae-nvidia commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Refactor
    • Updated internal type definitions to align with SDK schema variants. No changes to functionality or user-facing behavior.

Signed-off-by: Sean Teramae <steramae@nvidia.com>
@steramae-nvidia
steramae-nvidia requested review from a team as code owners June 11, 2026 20:48
@github-actions github-actions Bot added the fix label Jun 11, 2026
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c3717a2f-8766-44dd-befc-a30062dfcdb7

📥 Commits

Reviewing files that changed from the base of the PR and between 53b6c8b and 3c1634b.

📒 Files selected for processing (2)
  • web/packages/studio/src/components/dataViews/GuardrailsDataView/guardrailUtils.test.ts
  • web/packages/studio/src/components/dataViews/GuardrailsDataView/guardrailUtils.ts

📝 Walkthrough

Walkthrough

Updates the countRails utility function and its tests to use RailsConfigOutput type instead of RailsConfig. The function behavior and logic remain unchanged; only the type signature aligns with the SDK schema variant used by guardrails code.

Changes

Rails Type Alignment

Layer / File(s) Summary
Function signature and import
web/packages/studio/src/components/dataViews/GuardrailsDataView/guardrailUtils.ts
countRails function parameter type changed from RailsConfig | undefined to optional RailsConfigOutput, with import updated to match.
Test data type annotations
web/packages/studio/src/components/dataViews/GuardrailsDataView/guardrailUtils.test.ts
Test file import and all test data annotations (empty rails, flow counting, partial rails) updated from RailsConfig to RailsConfigOutput.

Possibly Related PRs

  • NVIDIA-NeMo/nemo-platform#273: Prior PR modified the same countRails signature and test fixtures, switching to RailsConfig (opposite direction from this PR's RailsConfigOutput change).

Suggested Reviewers

  • htolentino-nvidia
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title clearly summarizes the main change: updating guardrails type definitions from RailsConfig to RailsConfigOutput.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch steramae/rails-types

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 19018/25211 75.4% 61.4%
Integration Tests 11013/23983 45.9% 20.4%

Signed-off-by: Sean Teramae <steramae@nvidia.com>
@steramae-nvidia
steramae-nvidia added this pull request to the merge queue Jun 11, 2026
Merged via the queue into main with commit 4dcfc4b Jun 11, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants