Skip to content

refactor(studio): Remove old files#330

Merged
steramae-nvidia merged 3 commits into
mainfrom
steramae/remove-old-files
Jun 16, 2026
Merged

refactor(studio): Remove old files#330
steramae-nvidia merged 3 commits into
mainfrom
steramae/remove-old-files

Conversation

@steramae-nvidia

@steramae-nvidia steramae-nvidia commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Added a new script to fetch styles for the studio package.
  • Chores

    • Removed deprecated development scripts and migration utilities.
    • Simplified environment configuration.
    • Removed Skaffold deployment configuration.

Signed-off-by: Sean Teramae <steramae@nvidia.com>
@steramae-nvidia
steramae-nvidia requested review from a team as code owners June 15, 2026 16:18
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 8d5793fe-99da-492f-9d7f-3995662ee9fd

📥 Commits

Reviewing files that changed from the base of the PR and between e2cb4f6 and 0ccd003.

📒 Files selected for processing (1)
  • web/packages/studio/package.json
💤 Files with no reviewable changes (1)
  • web/packages/studio/package.json

📝 Walkthrough

Walkthrough

Removes three one-time migration scripts (rename-nemo-studio.ts, icon-migration-map.ts, jsonlFilters.ts) and their package.json entry from web/packages/scripts. Adds a fetch-styles script to web/packages/studio/package.json. Deletes web/skaffold.yaml and clears four env vars from web/skaffold.env.

Changes

Script cleanup and Skaffold removal

Layer / File(s) Summary
Remove migration scripts and add fetch-styles
web/packages/scripts/package.json, web/packages/scripts/src/rename-nemo-studio.ts, web/packages/scripts/src/icon-migration-map.ts, web/packages/scripts/src/jsonlFilters.ts, web/packages/studio/package.json
rename-nemo-studio script entry removed from scripts package; source files (rename-nemo-studio.ts, icon-migration-map.ts, jsonlFilters.ts) deleted. fetch-styles script added to studio package.
Remove Skaffold frontend config and env
web/skaffold.yaml, web/skaffold.env
web/skaffold.yaml (frontend Skaffold Config with four profile dependencies) deleted; CI_COMMIT_SHA, CI_COMMIT_SHORT_SHA, K8S_NAMESPACE_PREFIX, K8S_NAMESPACE_SUFFIX removed from web/skaffold.env.

Suggested Reviewers

  • aray12
  • walston
  • crookedstorm
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title "refactor(studio): Remove old files" is vague and generic, using non-descriptive language that doesn't convey what specific files were removed or why. Specify which files are being removed, e.g., "refactor: Remove icon migration and skaffold configs" or "refactor: Clean up unused build and migration scripts".
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch steramae/remove-old-files

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
web/packages/scripts/package.json (1)

6-15: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Add required test:ci script to opt this package into CI test checks.

typecheck is present, but test:ci is missing from this web/**/package.json. Add a non-watch CI test command (for example vitest run --coverage) in scripts.

As per coding guidelines, "web/**/package.json: Add test:ci script to package.json to opt a package into CI checks; this script should run tests in CI with appropriate config like coverage and non-watch mode (e.g., vitest run --coverage)."

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@web/packages/scripts/package.json` around lines 6 - 15, The scripts object in
package.json is missing a `test:ci` entry required to opt this package into CI
test checks. Add a new `test:ci` script entry to the scripts section that runs
tests in non-watch mode with coverage reporting (for example, using `vitest run
--coverage` or equivalent test runner command) to enable CI test verification
for this package.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@web/packages/scripts/package.json`:
- Around line 6-15: The scripts object in package.json is missing a `test:ci`
entry required to opt this package into CI test checks. Add a new `test:ci`
script entry to the scripts section that runs tests in non-watch mode with
coverage reporting (for example, using `vitest run --coverage` or equivalent
test runner command) to enable CI test verification for this package.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 91ce7dbf-16e0-4df8-b1cc-6d33c0df5672

📥 Commits

Reviewing files that changed from the base of the PR and between ca553ae and e2cb4f6.

📒 Files selected for processing (7)
  • web/packages/scripts/package.json
  • web/packages/scripts/src/icon-migration-map.ts
  • web/packages/scripts/src/jsonlFilters.ts
  • web/packages/scripts/src/rename-nemo-studio.ts
  • web/packages/studio/scripts/fetch-styles.ts
  • web/skaffold.env
  • web/skaffold.yaml
💤 Files with no reviewable changes (6)
  • web/packages/scripts/src/jsonlFilters.ts
  • web/packages/scripts/src/icon-migration-map.ts
  • web/skaffold.env
  • web/skaffold.yaml
  • web/packages/studio/scripts/fetch-styles.ts
  • web/packages/scripts/src/rename-nemo-studio.ts

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 19462/25829 75.3% 60.9%
Integration Tests 11371/24601 46.2% 20.2%

Comment thread web/packages/studio/scripts/fetch-styles.ts
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
@steramae-nvidia
steramae-nvidia added this pull request to the merge queue Jun 16, 2026
Merged via the queue into main with commit 8830c02 Jun 16, 2026
53 checks passed
@steramae-nvidia
steramae-nvidia deleted the steramae/remove-old-files branch June 16, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants