refactor(studio): Remove old files#330
Conversation
Signed-off-by: Sean Teramae <steramae@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughRemoves three one-time migration scripts ( ChangesScript cleanup and Skaffold removal
Suggested Reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
web/packages/scripts/package.json (1)
6-15:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd required
test:ciscript to opt this package into CI test checks.
typecheckis present, buttest:ciis missing from thisweb/**/package.json. Add a non-watch CI test command (for examplevitest run --coverage) inscripts.As per coding guidelines, "
web/**/package.json: Addtest:ciscript topackage.jsonto opt a package into CI checks; this script should run tests in CI with appropriate config like coverage and non-watch mode (e.g.,vitest run --coverage)."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@web/packages/scripts/package.json` around lines 6 - 15, The scripts object in package.json is missing a `test:ci` entry required to opt this package into CI test checks. Add a new `test:ci` script entry to the scripts section that runs tests in non-watch mode with coverage reporting (for example, using `vitest run --coverage` or equivalent test runner command) to enable CI test verification for this package.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@web/packages/scripts/package.json`:
- Around line 6-15: The scripts object in package.json is missing a `test:ci`
entry required to opt this package into CI test checks. Add a new `test:ci`
script entry to the scripts section that runs tests in non-watch mode with
coverage reporting (for example, using `vitest run --coverage` or equivalent
test runner command) to enable CI test verification for this package.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 91ce7dbf-16e0-4df8-b1cc-6d33c0df5672
📒 Files selected for processing (7)
web/packages/scripts/package.jsonweb/packages/scripts/src/icon-migration-map.tsweb/packages/scripts/src/jsonlFilters.tsweb/packages/scripts/src/rename-nemo-studio.tsweb/packages/studio/scripts/fetch-styles.tsweb/skaffold.envweb/skaffold.yaml
💤 Files with no reviewable changes (6)
- web/packages/scripts/src/jsonlFilters.ts
- web/packages/scripts/src/icon-migration-map.ts
- web/skaffold.env
- web/skaffold.yaml
- web/packages/studio/scripts/fetch-styles.ts
- web/packages/scripts/src/rename-nemo-studio.ts
|
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Summary by CodeRabbit
New Features
Chores