fix(studio): replace missing MetricBundleInput type#392
Merged
Conversation
Signed-off-by: Octavian Drulea <odrulea@nvidia.com>
htolentino-nvidia
approved these changes
Jun 22, 2026
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesMetricRunSidePanel type update
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
nv-odrulea
enabled auto-merge
June 22, 2026 20:42
Contributor
|
mckornfield
approved these changes
Jun 22, 2026
tylersbray
added a commit
that referenced
this pull request
Jun 22, 2026
Rebase onto current main to pick up evaluator MetricFilter fix (#392) that caused merge-queue lint-openapi/lint-web-sdk failures. Commit the generated deployments plugin OpenAPI spec alongside other opted-in plugins. Signed-off-by: Tyler Bray <tbray@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
The evaluator was recently migrated to a plugin format. As part of that migration, EvaluateInputSpec.metrics changed from
MetricBundleInput[]to(MetricInline | MetricRef)[]and `MetricBundleInput`` was removed from the generated SDK schema entirely.MetricRunSidePanelstill importedMetricBundleInputand cast metric to that type at two call sites, breaking thepackages/studiotypecheck job in CI.Fix
Swap the import and both cast sites:
MetricBundleInput→MetricInline. The cast is structural:MetricItemWithId(from the evaluator metric entity) aligns withMetricInlineso this is a rename, not a behavioral change.Files changed
web/packages/studio/src/components/sidePanels/MetricRunSidePanel/index.tsxSummary by CodeRabbit