Skip to content

fix(studio): replace missing MetricBundleInput type#392

Merged
nv-odrulea merged 1 commit into
mainfrom
od/fix-evaluator-types
Jun 22, 2026
Merged

fix(studio): replace missing MetricBundleInput type#392
nv-odrulea merged 1 commit into
mainfrom
od/fix-evaluator-types

Conversation

@nv-odrulea

@nv-odrulea nv-odrulea commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace removed MetricBundleInput import with MetricInline in MetricRunSidePanel

Context

The evaluator was recently migrated to a plugin format. As part of that migration, EvaluateInputSpec.metrics changed from MetricBundleInput[] to (MetricInline | MetricRef)[] and `MetricBundleInput`` was removed from the generated SDK schema entirely.

MetricRunSidePanel still imported MetricBundleInput and cast metric to that type at two call sites, breaking the packages/studio typecheck job in CI.

Fix

Swap the import and both cast sites: MetricBundleInputMetricInline. The cast is structural: MetricItemWithId (from the evaluator metric entity) aligns with MetricInline so this is a rename, not a behavioral change.

Files changed

web/packages/studio/src/components/sidePanels/MetricRunSidePanel/index.tsx

Summary by CodeRabbit

  • Bug Fixes
    • Fixed metric evaluation job request formatting. Updated how metrics are processed when building evaluation requests for both online and offline jobs to use the correct data structure, ensuring metrics are properly handled during job execution.

Signed-off-by: Octavian Drulea <odrulea@nvidia.com>
@nv-odrulea
nv-odrulea requested review from a team as code owners June 22, 2026 20:37
@github-actions github-actions Bot added the fix label Jun 22, 2026
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: eabb9dc9-94d6-4921-b9a2-4be4f9b29e70

📥 Commits

Reviewing files that changed from the base of the PR and between a7f031b and 7cf5053.

📒 Files selected for processing (1)
  • web/packages/studio/src/components/sidePanels/MetricRunSidePanel/index.tsx

📝 Walkthrough

Walkthrough

MetricRunSidePanel swaps the evaluator schema type from MetricBundleInput to MetricInline. The import is updated and both the online and offline EvaluateJobRequest metrics array construction sites cast metric as MetricInline.

Changes

MetricRunSidePanel type update

Layer / File(s) Summary
MetricInline import and cast
web/packages/studio/src/components/sidePanels/MetricRunSidePanel/index.tsx
Replaces MetricBundleInput with MetricInline in the import and in both online and offline request.spec.metrics cast sites.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title accurately identifies the main change: replacing MetricBundleInput with MetricInline due to SDK schema migration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch od/fix-evaluator-types

Comment @coderabbitai help to get the list of available commands and usage tips.

@nv-odrulea
nv-odrulea enabled auto-merge June 22, 2026 20:42
@github-actions

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 20910/27422 76.2% 61.4%
Integration Tests 12008/26191 45.9% 19.3%

@nv-odrulea
nv-odrulea added this pull request to the merge queue Jun 22, 2026
Merged via the queue into main with commit 5279d50 Jun 22, 2026
91 of 94 checks passed
@nv-odrulea
nv-odrulea deleted the od/fix-evaluator-types branch June 22, 2026 21:40
tylersbray added a commit that referenced this pull request Jun 22, 2026
Rebase onto current main to pick up evaluator MetricFilter fix (#392)
that caused merge-queue lint-openapi/lint-web-sdk failures. Commit the
generated deployments plugin OpenAPI spec alongside other opted-in plugins.

Signed-off-by: Tyler Bray <tbray@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants