ASTD-259: Add missing deps to handleInferFromExisting

[marcusds]

Summary

Fixes ASTD-259: The handleInferFromExisting useCallback was missing workspace and datasetName from its dependency array, causing stale values after route changes.

Changes

• Added workspace and datasetName to the useCallback dependency array
• Removed the incorrect eslint-disable comment

Testing

• Verified the dependency array now includes all referenced values

Summary by CodeRabbit

• Chores
  • Internal improvements made to the dataset schema editor component to enhance code quality, reliability, and maintainability without affecting user experience.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6d496249-f048-45c0-8586-545f5335f4f6

📥 Commits

Reviewing files that changed from the base of the PR and between b021449 and 6eceba7.

📒 Files selected for processing (1)

• web/packages/studio/src/routes/FilesetDetailRoute/DatasetSchemaEditor/useDatasetSchemaEditor.ts

---

📝 Walkthrough

Walkthrough

handleInferFromExisting's useCallback dependency array in useDatasetSchemaEditor is updated to include workspace and datasetName. The eslint-disable comment that previously suppressed the missing-deps warning is removed.

Changes

useCallback Dependency Fix

Layer / File(s)	Summary
Add missing useCallback deps web/packages/studio/src/routes/FilesetDetailRoute/DatasetSchemaEditor/useDatasetSchemaEditor.ts	workspace and datasetName added to handleInferFromExisting dependency array; eslint suppression comment removed.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	Title directly and clearly summarizes the main change: adding missing dependencies to the handleInferFromExisting hook to fix a stale closure bug.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch mschwab/astd-259-datasetschemaeditor-stale-deps

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Suite	Lines Covered	Line Rate	Branch Rate
Unit Tests	21176/27762	76.3%	61.2%
Integration Tests	12216/26531	46.0%	19.5%