This repository was archived by the owner on Jan 7, 2025. It is now read-only.
Closed
Conversation
This was referenced Aug 26, 2016
| Base class | ||
| """ | ||
| SAVE_FILE = 'status.pickle' | ||
| NON_PERSISTENT_JOB_DELETE_TIMEOUT_SECONDS = 3600 |
Contributor
There was a problem hiding this comment.
that makes it a class attribute, is this what you want? or shall this be an instance attribute?
Contributor
Author
There was a problem hiding this comment.
@gheinrich I feel like setting job time out would be more class specific then instance specific. Ie all get_weights jobs would have the same timeout, vs individual instances of get_weights jobs.
Lucaszw
force-pushed
the
add_custom_delete_job_timeouts
branch
3 times, most recently
from
db2b0b3 to
4e9d6d1
Compare
added setter
Member
|
Sorry, but how is this a bug? This PR doesn't appear to change any behavior. |
Contributor
Author
|
@lukeyeager My bad, yeah this should be an enhancement. |
Member
|
Closing because there are merge conflicts from #1207 and because this was a no-op change anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add custom delete job timeouts