Skip to content

Refactor out live view only example#762

Merged
jiwenc-nv merged 2 commits into
NVIDIA:mainfrom
nv-jakob:jakob/refactor-out-live-view-only-viser
Jul 14, 2026
Merged

Refactor out live view only example#762
jiwenc-nv merged 2 commits into
NVIDIA:mainfrom
nv-jakob:jakob/refactor-out-live-view-only-viser

Conversation

@nv-jakob

@nv-jakob nv-jakob commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #(issue)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Documentation update

Testing

Checklist

  • I have read and understood the contribution guidelines
  • I have run the linter and formatter with SKIP=check-copyright-year pre-commit run --all-files
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix/feature works (or explained why not)
  • I have signed off all my commits (git commit -s) per the DCO

Summary by CodeRabbit

  • New Features
    • Added a new live DeviceIO browser example that shows hands, head, controllers, and full-body tracking together in real time.
    • Included a new example build target so the live view ships when examples are enabled.
  • Documentation
    • Updated the DeviceIO recording/replay docs to point to the new live visualization example.

nv-jakob added 2 commits July 9, 2026 14:51
Signed-off-by: Jakob Bornecrantz <tbornecrantz@nvidia.com>
Signed-off-by: Jakob Bornecrantz <tbornecrantz@nvidia.com>
@nv-jakob nv-jakob requested a review from jiwenc-nv July 9, 2026 14:03
@nv-jakob nv-jakob changed the title Jakob/refactor out live view only viser Refactor out live view only viser Jul 9, 2026
@nv-jakob nv-jakob changed the title Refactor out live view only viser Refactor out live view only example Jul 9, 2026
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d42dc826-03db-4530-929b-ac322044cb53

📥 Commits

Reviewing files that changed from the base of the PR and between 83103b0 and 9595188.

📒 Files selected for processing (6)
  • CMakeLists.txt
  • docs/source/references/mcap_record_replay.rst
  • examples/deviceio_live_view/CMakeLists.txt
  • examples/deviceio_live_view/python/deviceio_viser.py
  • examples/deviceio_live_view/python/live_deviceio.py
  • examples/deviceio_live_view/python/pyproject.toml

📝 Walkthrough

Walkthrough

This PR adds a new example, examples/deviceio_live_view, integrated into the CMake build and documented in the MCAP record/replay reference. It introduces a Python module (deviceio_viser.py) that builds a combined human-tracking pipeline (hands, head, controllers, full body) and renders each tracker via viser-backed visualization classes. A runnable script (live_deviceio.py) drives a CloudXR/TeleopSession loop, feeding tracking results into the visualization and printing periodic status. A pyproject.toml defines packaging and dependencies for the example.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Script as live_deviceio.main
  participant Launcher as CloudXRLauncher
  participant Session as TeleopSession
  participant Viz as HumanDeviceIOViz
  participant Server as viser.ViserServer

  Script->>Launcher: launch_context()
  Script->>Session: create(TeleopSessionConfig)
  loop every frame
    Script->>Session: step()
    Session-->>Script: result
    Script->>Viz: update(result)
    Viz->>Server: update point clouds/segments/visibility
  end
  Script->>Script: KeyboardInterrupt breaks loop
Loading
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: extracting a dedicated live-view-only example.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

📝 Docs preview is not auto-deployed for fork PRs.

A maintainer with write access to NVIDIA/IsaacTeleop can deploy a preview by
commenting /preview-docs on this PR. Once deployed, the preview
will live at:

https://nvidia.github.io/IsaacTeleop/preview/pr-762/

@jiwenc-nv jiwenc-nv merged commit 6fb2f45 into NVIDIA:main Jul 14, 2026
46 checks passed
]

[[tool.uv.index]]
url = "https://pypi.nvidia.com"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't specify the index and the exact version spec so IT could be picked up from the build tree for local development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants