feat(cloudxr): add optional experimental runtime packaging - #808
Conversation
|
📝 Docs preview is not auto-deployed for fork PRs. A maintainer with write access to |
📝 WalkthroughWalkthroughAdds optional downloading and packaging of an experimental CloudXR SDK under Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Configure as CMake configure
participant Download as SDK downloader
participant Package as Python package
participant Runtime as CloudXR runtime
participant Launcher as CloudXRLauncher
Configure->>Download: request standard and optional experimental SDKs
Download-->>Configure: provide SDK tarballs
Configure->>Package: extract native and native_exp bundles
Runtime->>Package: select bundle using ISAAC_TELEOP_CLOUDXR_EXP
Runtime->>Launcher: provide selected SDK path
Launcher->>Runtime: start worker with selected library paths
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
c8e156c to
d82db26
Compare
3612dfc to
9ca50fc
Compare
e5b0c6a to
b6c10e1
Compare
Add -DENABLE_CLOUDXR_EXP_BUNDLE=ON to ship isaacteleop.cloudxr_exp natives in the same wheel. Select with ISAAC_TELEOP_CLOUDXR_EXP; on Tegra T234 prefer exp automatically (fail if missing; ISAAC_TELEOP_CLOUDXR_EXP=0 forces stable). Signed-off-by: Michael Haselton <mhaselton@nvidia.com>
b6c10e1 to
2433553
Compare
Description
Opt-in packaging for a sibling experimental CloudXR runtime package
(
isaacteleop.cloudxr_expwith its ownnative/) in the same wheel as thedefault
isaacteleop.cloudxrbundle.-DENABLE_CLOUDXR_EXP_BUNDLE=ON(default OFF) downloads/packages theexp tarball when available;
ENABLE_CLOUDXR_BUNDLE_CHECKstill owns hard-failvs warn for missing artifacts.
ISAAC_TELEOP_CLOUDXR_EXPselects stable vs exp viaresolve_cloudxr_runtime_module()/get_sdk_path()(used byCloudXRLauncher). On Tegra T234, exp is preferred automatically when theenv is unset; missing exp fails (set
ISAAC_TELEOP_CLOUDXR_EXP=0to forcestable). Explicit
ISAAC_TELEOP_CLOUDXR_EXP=1also fails if exp is not inthe wheel.
the cmake/tarball side (including Orin / TeleViz motivation for exp).
Public CI remains stable-only (flag stays OFF). Layout is ready for a later
dedicated-wheel split if needed.
Type of change
Testing
test_runtime.py(selection helpers,resolve_cloudxr_runtime_module,get_sdk_path).CXR_RUNTIME_SDK_VERSION=222d1f93 cmake -B build -DENABLE_CLOUDXR_EXP_BUNDLE=ONcp311wheel;ISAAC_TELEOP_CLOUDXR_EXP=0→…/cloudxr/native(StreamSDKgcomp/rel/gs_04_86);ISAAC_TELEOP_CLOUDXR_EXP=1→…/cloudxr_exp/native(StreamSDKgcomp/dev); both report CloudXR6.3.0viaruntime_version()inseparate processes.
Checklist
SKIP=check-copyright-year pre-commit run --all-filesgit commit -s) per the DCOSummary by CodeRabbit
New Features
Documentation
Tests