Log app_finish_time and app_train_loop_finish_time on early-exit path#5864
Merged
Merged
Conversation
The exit-duration/exit-interval/signal exit path sys.exit()s before the normal-path one-logger logging, leaving both timestamps unset on otherwise COMPLETED jobs. This mis-attributes end-of-run time (shutdown -> uncategorized). Log both timestamps on the should_exit path so shutdown time is recorded. Signed-off-by: Ali Arda Eker <aeker@nvidia.com>
svcnvidia-nemo-ci
marked this pull request as draft
July 17, 2026 18:39
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
jiemingz
approved these changes
Jul 17, 2026
svcnvidia-nemo-ci
added
the
waiting-on-maintainers
Contributor
|
/ok to test 64ab8c7 |
Contributor
|
/claude review |
asolergi-nv
approved these changes
Jul 20, 2026
ericharper
enabled auto-merge
July 20, 2026 21:58
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
svcnvidia-nemo-ci
removed
the
waiting-on-maintainers
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/29810693082 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Log app_finish_time and app_train_loop_finish_time on early-exit path
The exit-duration/exit-interval/signal exit path sys.exit()s before the normal-path one-logger logging, leaving both timestamps unset on otherwise COMPLETED jobs. This mis-attributes end-of-run time (shutdown -> uncategorized). Log both timestamps on the should_exit path so shutdown time is recorded.
Contribution process
Pre-checks
Code review
Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.