Populate dp process group in auto-built ProcessGroupCollection in pipeline schedules - #5901
Merged
Merged
Conversation
…eline schedules Split from NVIDIA#3386 (sequence packing / THD E2E support). Original changes by @xiaoyao0115 in NVIDIA#3386. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: ilml <tolong@nvidia.com>
This was referenced Jul 20, 2026
yaoyu-33
approved these changes
Jul 20, 2026
guihong-nv
approved these changes
Jul 22, 2026
jiemingz
reviewed
Jul 23, 2026
…nto a helper The fallback pg_collection construction was repeated in all three schedule entry points (no-pipelining, interleaved, non-interleaved). Consolidate it into _build_default_pg_collection(); the interleaved and non-interleaved sites keep their local tp_group/cp_group/cp_size bindings by reading them off the returned collection. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Tom Long <tolong@nvidia.com>
jiemingz
approved these changes
Jul 27, 2026
svcnvidia-nemo-ci
added
Approved
Contributor
Author
|
/ok to test be08e66 |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/30339663477 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Populates
pg_collection.dpin thepg_collection is Nonefallback of the three forward-backward schedules (no-pipelining, interleaved, non-interleaved), matching the MPU default groups. Groundwork for sequence-packing stats collectives; no behavior change for existing callers.Part 01/10 of splitting #3386 (Add E2E support for THD format; dev-branch PR #2924). Original changes by @xiaoyao0115 in #3386 — split into functionally self-contained PRs to ease review. Hard dependencies (must merge first): none — independently mergeable.
Split series (#3386)
Branches are stacked linearly (each on the previous) so every PR shows a clean own-diff once its base is retargeted to the copy-pr-bot
pull-request/<parent>ref; until then the Files-changed view of a stacked PR includes its ancestors — its own change is the last commit.Issue tracking
Linked issue: Related to #3386
Contribution process
Pre-checks
🤖 Generated with Claude Code