fix(ci): AUT-957 support golden checks in merge queue#5989
Merged
ko3n1g merged 2 commits intoJul 23, 2026
Conversation
![[Co-author Name]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
- Introduced a new step in the CI workflow to validate golden-value JSON files for NaN and infinity values. - Added a new script, `check_golden_values.py`, to perform the validation checks on the specified files. - The validation step is triggered during pull request pushes, ensuring that any updates to golden values are properly checked before merging. Signed-off-by: [Your Name] <your.email@example.com> Co-authored-by: [Co-author Name] <coauthor.email@example.com> Signed-off-by: Ajay Balasa <abalasa@nvidia.com> Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
svcnvidia-nemo-ci
marked this pull request as draft
July 23, 2026 07:38
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
ko3n1g
approved these changes
Jul 23, 2026
Collaborator
Author
|
/ok to test a6eb587 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Merge-group run 29983603449 failed in
linting:get-pr-infois skipped formerge_group, while the golden-value step evaluatedfromJSONon its empty output and made the workflow template invalid. The PR event path itself passed in run 29902228424.What changed
merge_group.base_ref, with safe PR metadata fallback.refs/heads/prefix before fetching and diffing.main.Details
.github/workflows/cicd-main.ymlnow avoids parsing an emptyget-pr-infooutput and uses the merge-group event payload directly.tools/check_golden_values.pyis unchanged from #5959.Tested
uv sync --locked --only-group lintingBASE_REF=main CHECK_ONLY=true SKIP_DOCS=false bash tools/autoformat.shtools/check_golden_values.py