test(optimizer): MCORE-560 cover MoE gradient zero counts - #6050
Merged
Conversation
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
svcnvidia-nemo-ci
marked this pull request as draft
July 26, 2026 08:39
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
Author
|
/ok to test b132d32 |
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Collaborator
Author
|
/ok to test a6445bd |
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Collaborator
Author
|
/ok to test 3ba0d46 |
Collaborator
Author
|
/ok to test 0333e00 |
Collaborator
Author
|
/ok to test 0333e00 |
ko3n1g
approved these changes
Jul 29, 2026
ko3n1g
added
the
core_r0.19.0
Contributor
|
@svcnemo-autobot fetch and merge upstream/main and set to auto-merge |
Contributor
|
🛑 This session reached its turn budget — stopping to avoid runaway cost. Open a new request if there is more to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
MCORE-560 followed the gradient-accounting correction in #5916. Its initial merge-queue head shifted deterministic loss and zero-count metrics before every affected golden was updated; the final merged change included those updates.
What changed
Details
tests/unit_tests/training/test_param_norm.pyasserts that an entirely zero logical model reports the reference model's full parameter count across topologies, then checks all-one gradients report zero alongside norm and clipping invariance.Tested
git diff --checkci-events-agent-write-4607a401(pending)