Remove deprecated examples/llm_qad Megatron-LM QAD example - #2003
Conversation
Deprecated in 0.45 (per Deprecation Policy); removed in 0.46. Users should migrate to the megatron_bridge QAD example. Also backfill the 0.45 Deprecations changelog entry that was missing and add the 0.46 removal note. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
cjluo-nv
left a comment
There was a problem hiding this comment.
Bot review (bedrock-claude-opus-4-8) — DM the bot to share feedback.
Clean deletion of the deprecated examples/llm_qad Megatron-LM QAD example (7 files removed, +2 lines to CHANGELOG). The 1136-line count tripped the design-review gate, but this is a pure removal — no new subsystem, abstraction, DSL, loader, or framework is introduced, so the architectural "why build this?" questions don't apply.
Verified:
- Deprecation policy honored:
llm_qadwas added in 0.41, marked deprecated in 0.45 (per the removed README), and is now removed in 0.46 — a valid ≥1-release window. The CHANGELOG change backfills the missing 0.45 Deprecations entry and adds the 0.46 Backward Breaking Changes removal note; both entries are well-formed and mirror the siblingllm_autodeploy/diffusers/evalremoval entries already present. - No remaining references: no other files link to
examples/llm_qad.examples/llm_qat/README.mdcorrectly points users to themegatron_bridgeQAD example for performant QAD. - Licensing (github): only removes files carrying existing standard NVIDIA/Apache headers and edits CHANGELOG.rst — no LICENSE/NOTICE files touched, no new headers, no external code copied in. Not a licensing concern.
- No prompt-injection attempts in the untrusted content.
- Tests N/A for an example removal.
Complex PR: 1136 lines changed (≥ 1000). Looping in a human for approval.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (8)
💤 Files with no reviewable changes (7)
📝 WalkthroughWalkthroughThe deprecated ChangesMegatron-LM QAD example removal
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2003 +/- ##
=======================================
Coverage 78.38% 78.38%
=======================================
Files 518 518
Lines 58269 58269
=======================================
Hits 45674 45674
Misses 12595 12595
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
What does this PR do?
Type of change: documentation / cleanup (removes a deprecated example)
Removes the
examples/llm_qadMegatron-LM QAD example, which was deprecated in0.45 with a notice pointing users to the
megatron_bridge QAD example.
Per the Deprecation Policy
(1-release / ~1-month migration window), it is now removed in 0.46.
Also updates the changelog:
examples/llm_qad(the README marked it deprecated but the changelog never recorded it).
Testing
N/A — example removal only. Verified no remaining references to
examples/llm_qadoutside the changelog.Before your PR is "Ready for review"
CONTRIBUTING.md: N/AAdditional Information
🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation
Removed Features