Refactor 0.46.0 Changelog - #2052
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthrough
ChangesRelease changelog updates
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/ok to test d492c12 |
cjluo-nv
left a comment
There was a problem hiding this comment.
Bot review (bedrock-claude-opus-5) — DM the bot to share feedback.
Docs-only change: reorganizes the 0.46 CHANGELOG entries into *Quantization* / *Speculative Decoding* / *Megatron Framework* / *Misc* subgroups (matching the existing 0.45 style), folds the top-level Experimental section into 0.46 Misc as an (Experimental) bullet, and opens a 0.47 placeholder section.
I fetched the full file at the PR branch and verified nothing was dropped in the shuffle — every removed bullet (D-PACE, streaming spec-dec, Domino, CP/DP, Minitron variants + sub-bullets, VLM prune/PTQ/distill, day0-release, --target_dla, prepare_megatron_data_blend, puzzletron) reappears exactly once, and no duplicates were introduced. The mis-nested "Nested submodel reverse mappings…" paragraph is correctly promoted from an indented continuation of the ONNX FP16/BF16 bullet to its own Bug Fixes bullet. RST structure (heading underline length, bullet indentation for sub-lists) is valid.
Two entries are net-new rather than moved (grouped-GEMM TEGroupedMLP Minitron pruning with --no_moe_grouped_gemm, and distill.py --checkpoint_keep_last -1 / export_distilled_megatron_to_hf.py --export_iterations); I confirmed both features exist in the repo (examples/megatron_bridge/prune_minitron.py, examples/megatron_bridge/README.md + tests), so these look like previously-missing changelog entries being backfilled — fine, just slightly beyond "refactor".
Minor, non-blocking: the new 0.47 section is four bold headers with no content yet, and 0.46 is still dated 2026-08-xx (unreleased) — if 0.46 hasn't shipped, the 0.47 stub may be premature. No licensing files touched, no tests needed for a changelog-only change.
There was a problem hiding this comment.
Warning
CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.
Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.rst`:
- Around line 79-80: Move the VILA/NVILA support removal and minimum NeMo
container requirement entries from the `**Deprecations**` section into
`**Backward Breaking Changes**` in `CHANGELOG.rst`, preserving their existing
text and order. Keep `**Deprecations**` limited to changes that remain
functional during migration.
- Line 71: Update the recommendation in the changelog entry to direct users to
the canonical examples/hf_ptq path instead of the compatibility examples/llm_ptq
symlink, while preserving the existing AutoDeploy guidance.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: f8814572-9714-4a06-a1a4-9e40718d52f0
📒 Files selected for processing (1)
CHANGELOG.rst
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
d492c12 to
954129c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2052 +/- ##
=======================================
Coverage 66.94% 66.94%
=======================================
Files 519 519
Lines 59401 59401
=======================================
Hits 39767 39767
Misses 19634 19634
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Refactor 0.46.0 Changelog organization
Summary by CodeRabbit