docs(diffusers): clarify --calib-size is samples/prompts, not steps - #2058
docs(diffusers): clarify --calib-size is samples/prompts, not steps#2058felipeofdev-ai wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe calibration CLI now accepts ChangesCalibration CLI documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Fixes NVIDIA#247 — help text now states calib-size counts calibration samples/prompts (with batch ceil note) and points to --n-steps for denoising steps. Signed-off-by: Felipe Fernandes <felipe.of.dev@gmail.com>
8b4588b to
5d78e42
Compare
Completes the backward-compatible alias requested in NVIDIA#247. Signed-off-by: Felipe Fernandes <felipe.of.dev@gmail.com>
|
Thanks for reviewing — CI is green on my side. Happy to adjust anything you need. — Felipe Fernandes · Systems & Agentic AI Engineer |
e642dda to
81508cf
Compare
Summary
Clarifies
--calib-sizehelp inexamples/diffusers/quantization/quantize.pyso it is not confused with denoising steps.Changes
--batch-size--n-stepsfor denoising stepsFixes #247
Test plan
python quantize.py --helpshows the new help stringSummary by CodeRabbit
--calib-sizeoption to explain calibration sample and prompt counts.--n-steps.— Felipe Fernandes · Systems & Agentic AI Engineer
https://github.com/felipeofdev-ai · https://felipeofdev-ai.github.io/
Summary by CodeRabbit
--calib-samplesas an alternative to--calib-size.