Give each example lane its own Codecov flag - #2111
Merged
Merged
Conversation
Every example lane uploaded under a shared `examples` flag. That was fine while all lanes ran on every PR, but #2090 gates them independently, and carryforward only applies to a flag with no upload on the commit. With a shared flag a single-lane PR uploads that flag as present but partial, so Codecov replaces the whole picture with the subset that ran and reports a coverage drop for code the PR never touched. One flag per example (examples-<name>) restores the intent: a lane that skips has no upload for its flag and is carried forward, while a lane that ran replaces only its own slice. gpu_tests keeps a single `gpu` flag: its suites are gated at workflow level, so they upload together or not at all. It would need the same treatment if per-suite gating is ever added. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2111 +/- ##
==========================================
+ Coverage 78.60% 78.73% +0.13%
==========================================
Files 522 522
Lines 60167 60167
==========================================
+ Hits 47294 47374 +80
+ Misses 12873 12793 -80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: CI/CD bug fix
Every example lane uploaded coverage under one shared
examplesflag. That was correct while all lanes ran on every PR, but #2090 gates them independently, and Codecov carryforward only applies to a flag with no upload on the commit.examplesflagThe third row is what gating made routine: a PR touching only
examples/diffusers/**runs the onnx lane, uploadsexamplescontaining onnx coverage alone, and Codecov reports a drop for code the PR never touched.One flag per example (
examples-<name>, 12 flags) restores the intent already documented in.github/codecov.yml: a skipped lane has no upload for its flag and is carried forward; a lane that ran replaces only its own slice. The config comment is updated to explain why a shared flag defeats carryforward, so this isn't re-introduced.gpu_testsdeliberately keeps a singlegpuflag — its five suites are gated at workflow level, so they upload together or not at all. It would need the same change if per-suite gating is ever added.Testing
Not directly observable on this PR: it changes workflow files, which are in the gate's
commongroup, so all twelve lanes run and every flag is uploaded — the healthy case either way. The behavior it fixes appears on the next PR that touches a single example, wherecodecov/projectshould now stay accurate instead of reporting a drop.Worth noting the symptom was never blocking:
codecov/projectis not a required check and the threshold allows a 2% drop. This is about the coverage data being right.Before your PR is "Ready for review"
examplesis unaffectedCONTRIBUTING.md: N/ASummary by CodeRabbit