[OMNIML-2244] enable fp8 and int8 ONNX export#594
Merged
Conversation
Signed-off-by: ajrasane <131806219+ajrasane@users.noreply.github.com>
Signed-off-by: ajrasane <131806219+ajrasane@users.noreply.github.com>
cjluo-nv
reviewed
Nov 21, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #594 +/- ##
==========================================
- Coverage 74.64% 74.57% -0.08%
==========================================
Files 183 183
Lines 18389 18412 +23
==========================================
+ Hits 13727 13730 +3
- Misses 4662 4682 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cjluo-nv
reviewed
Nov 24, 2025
|
|
||
|
|
||
| def replace_zero_scale_with_smallest_nonzero(onnx_model: onnx.ModelProto) -> onnx.ModelProto: | ||
| """Replace zero scale values with smallest nonzero fp16 value in the ONNX model.""" |
Collaborator
There was a problem hiding this comment.
could you document in what condition do we need to call this method here?
Contributor
Author
There was a problem hiding this comment.
Sorry, I had already set the MR to auto merge. Will add this in a follow up MR.
cjluo-nv
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change:
Example update
Overview:
Usage
Testing
Validated the accuracy and latency of int8 and fp8 models:
Before your PR is "Ready for review"