Skip to content

2.10.0dev0

  • 2.10.0dev0
  • 16dbf27

  • Partially verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.

  • Choose a tag to compare

    View all tags
2.10.0dev0: Improve external process timeout diagnostics (#5228)
  • 2.10.0dev0
  • 16dbf27

  • Choose a tag to compare

    View all tags

  • Partially verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
@YuanTingHsieh YuanTingHsieh tagged this 31 Aug 23:26 
## Summary

- add timeout-aware execution for the PyTorch external-process
end-to-end test
- include bounded captured process output and labeled simulator log
tails in timeout failures
- terminate the timed-out wrapper and its known descendants to avoid
contaminating later tests

## Motivation

The slow PyTorch external-process test previously surfaced only
subprocess.TimeoutExpired. Its useful simulator and client logs remained
under the temporary pytest workspace and were lost when the CI worker
was removed, leaving the hang without actionable diagnostics.

## Validation

- targeted PyTorch external-process end-to-end test: 1 passed
- forced-timeout diagnostic exercise confirmed process output and
simulator log tails are included
- full project style check: ./runtest.sh -s
- git diff --check

---------

Co-authored-by: Chester Chen <512707+chesterxgchen@users.noreply.github.com>
Assets 2
Loading