Forward-merge release/0.7 into main - #775
Merged
Merged
Conversation
Normalize Anthropic user-role tool_result blocks to OTel tool messages so Agent Observability can correlate and display their tool_call_response payloads. Preserve response as the payload key required by the OTel input-message JSON schema. #### Overview - [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license. - [x] I searched existing issues and open pull requests, and this does not duplicate existing work. #### Details Correct Claude tool-result projection in GenAI OpenTelemetry spans. Claude represents tool results as user messages containing only tool_result parts; NeMo Relay now projects these as role: "tool" messages so backends such as Datadog LLM Observability can associate tool calls with their results. #### Where should the reviewer start? N/A #### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to) None ## Summary by CodeRabbit - **Bug Fixes** - Corrected serialization of messages containing only tool results so they use the `tool` role instead of `user`. - Preserved tool call response details, including IDs and returned results, in GenAI telemetry. - Improved handling of messages with mixed tool-result and text content, as well as empty content arrays. - **Tests** - Added coverage for Claude-style tool-result messages and their normalized telemetry output. Authors: - Matthew Dwyer (https://github.com/Mluckydwyer) Approvers: - Will Killian (https://github.com/willkill07) URL: #768
Author
|
SUCCESS - forward-merge complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/0.7 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.