Forward-merge release/0.8 into main - #845
Merged
Merged
Conversation
#### Overview Preserve the name of every metadata attribute rejected during OpenTelemetry promotion. Runtime reports now expose one stable diagnostic per rejected key instead of collapsing all failures into one entry whose message names only the last key. - [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license. - [x] I searched existing issues and open pull requests, and this does not duplicate existing work. #### Details - Suffix the existing `otel.metadata_promotion_value_unsupported` diagnostic prefix with the rejected metadata key. - Record rejected keys in deterministic order. - Allow runtime diagnostic storage to own dynamically generated diagnostic codes. - Add regression coverage proving that four rejected keys remain independently identifiable across scope start and end events. - Update the existing unsupported-value test for the key-specific diagnostic code. This changes exact diagnostic-code matching from: `otel.metadata_promotion_value_unsupported` to: `otel.metadata_promotion_value_unsupported.<metadata-key>` Consumers that match diagnostic codes exactly should use the key-specific code or match the existing prefix. Validation: - Cursor public Python smoke passed with four independently named diagnostics. - Focused metadata-promotion regression tests passed. - `cargo fmt --all` passed. - `cargo clippy --workspace --all-targets -- -D warnings` passed. - File-scoped pre-commit checks and commit hooks passed. - `just test-rust` was not fully green in the local environment: - One run had two CLI host-status failures because Claude was observed as running. - A later aggregate run had shared plugin-registration failures; 1,502 core tests passed and 24 failed. The metadata-promotion-adjacent failure passed when run independently. - The Python suite was stopped before completion at the requested push boundary. - Go, Node.js, and all-file pre-commit validation were not run. #### Where should the reviewer start? Start with `OtelEventProcessor::promote_metadata` in `crates/core/src/observability/otel.rs`, then review `reports_each_unsupported_metadata_key_with_a_deterministic_diagnostic_code` in `crates/core/tests/unit/observability/otel_tests.rs`. #### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to) - Fixes RELAY-763 ## Summary by CodeRabbit * **Bug Fixes** * Improved observability diagnostics for unsupported metadata. * Diagnostics are now consistently ordered and identify the specific metadata key involved. * Unsupported metadata continues to be excluded from span attributes while producing clearer diagnostic details. * **Documentation** * Documented diagnostic codes, messages, occurrence counts, and monitoring guidance for rejected metadata values. Authors: - Eric Evans II (https://github.com/ericevans-nv) Approvers: - Will Killian (https://github.com/willkill07) URL: #840
Author
|
SUCCESS - forward-merge complete. |
github-actions
Bot
added
size:S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/0.8 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.