fix(uninstall): source nvm before npm uninstall to find the correct p…

[swqa-saiy]

Summary

Source nvm.sh before running npm uninstall -g nemoclaw in the curl-based uninstaller, and add a fallback that removes any leftover nemoclaw binary found under an nvm prefix.

Related Issue

Fixes #1959

Changes

• Add ensure_nvm_for_uninstall() that sources ~/.nvm/nvm.sh so npm resolves to the nvm-managed prefix
• Call it at the start of remove_nemoclaw_cli() before any npm operations
• Add post-uninstall fallback: if nemoclaw is still found under ~/.nvm/*/bin/, remove the binary and its lib/node_modules/nemoclaw entry directly
• Covers edge case where nvm's default alias points to a different Node.js version than the one used during install

Root cause: curl | bash runs in a non-interactive shell that does not source .bashrc/.zshrc, so nvm is not loaded. npm uninstall -g either fails (npm not on PATH) or targets the wrong global prefix (system npm vs nvm npm), leaving ~/.nvm/versions/node/v22.x/bin/nemoclaw behind.

nemoclaw uninstall --yes was unaffected because it runs from the nvm-installed Node.js which already has the correct npm on PATH.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Verification

• npx prek run --all-files passes
• npm test passes
• Tests added or updated for new or changed behavior
• No secrets, API keys, or credentials committed
• Docs updated for user-facing behavior changes

Manual test results

Tested on local machine (nvm v22.22.1, Ubuntu 22.04):

Scenario	Result
env -i clean shell (no nvm) + old code	❌ npm not found, nemoclaw left behind
env -i clean shell + new code (source nvm)	✅ npm found, nemoclaw removed
npm uninstall succeeds but binary remains (version mismatch)	✅ fallback rm removes leftover

AI Disclosure

• AI-assisted — tool: OpenClaw (Claude)

---

Signed-off-by: swqa-saiy swqa-saiy@users.noreply.github.com

Summary by CodeRabbit

• Bug Fixes
  • More reliable uninstall that fully removes leftover installation artifacts.
  • Improved compatibility with nvm so the uninstaller detects and cleans nvm-managed installations.
  • Added thorough scanning and removal of remaining binaries and modules across common Node/nvm installation locations.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a6d2fb3b-6b9e-48dc-bb9f-689076acb732

📥 Commits

Reviewing files that changed from the base of the PR and between a7be9ef and a395a94.

📒 Files selected for processing (1)

• uninstall.sh

🚧 Files skipped from review as they are similar to previous changes (1)

• uninstall.sh

---

📝 Walkthrough

Walkthrough

Adds NVM sourcing to the uninstall flow and extends CLI removal to scan and delete leftover nemoclaw binaries and modules under NVM-managed Node versions (defaulting to ~/.nvm/versions/node) in addition to existing shim and profile cleanup.

Changes

Cohort / File(s)	Summary
NVM-aware Uninstall Enhancement uninstall.sh	Added ensure_nvm_for_uninstall() and call from remove_nemoclaw_cli() to source nvm.sh (default ~/.nvm). Extended cleanup to search NVM_DIR/versions/node/**/bin/nemoclaw and .../lib/node_modules/nemoclaw and remove found binaries/modules, while keeping existing shim/profile/alias removals.

Sequence Diagram(s)

sequenceDiagram
    participant User as "User"
    participant Script as "uninstall.sh"
    participant NVM as "NVM (nvm.sh)"
    participant NPM as "npm/unlink"
    participant FS as "Filesystem (~/.nvm/versions)"

    rect rgba(200,230,255,0.5)
    User->>Script: run uninstall script
    Script->>NVM: ensure_nvm_for_uninstall() — source nvm.sh if present
    end

    rect rgba(200,255,200,0.5)
    Script->>NPM: run npm unlink/uninstall (uses nvm-managed prefix)
    NPM-->>Script: uninstall result
    end

    rect rgba(255,230,200,0.5)
    Script->>FS: scan NVM_DIR/versions/node/** for bin/nemoclaw and lib/node_modules/nemoclaw
    FS-->>Script: list of matches
    Script->>FS: remove matching files/directories
    end

    Script->>User: report completion

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 I hopped through ~/.nvm with care,
Sourced the script and cleared each lair,
Binaries and modules gone from sight,
PATH grows tidy in the pale moonlight. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: sourcing nvm before npm uninstall, which directly addresses the core issue of finding the correct npm prefix in the uninstall script.
Linked Issues check	✅ Passed	The PR fully addresses issue #1959 by sourcing nvm before npm operations and adding fallback cleanup of nvm-managed nemoclaw artifacts, ensuring complete removal from PATH.
Out of Scope Changes check	✅ Passed	All changes in uninstall.sh are directly scoped to fixing the nvm-related uninstall issue; no out-of-scope modifications were introduced.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@uninstall.sh`:
- Around line 383-399: The current cleanup only runs when command -v nemoclaw
finds a binary and therefore misses leftover installs in other NVM prefixes;
change the logic in the block using remaining/mod_dir to instead scan
${NVM_DIR:-$HOME/.nvm}/versions/node/* for versions containing bin/nemoclaw and
lib/node_modules/nemoclaw and remove them regardless of PATH. Concretely,
replace the outer "if command -v nemoclaw" guard with a loop over
"${NVM_DIR:-$HOME/.nvm}/versions/node" entries, for each candidate check for
"$candidate/bin/nemoclaw" and remove it (logging via info "Removed leftover
nemoclaw binary at ...") and then check and rm -rf
"$candidate/lib/node_modules/nemoclaw" (logging as well); preserve the existing
variable names (remaining/mod_dir) or use descriptive equivalents and keep
redirects like 2>/dev/null to avoid errors when directories are absent.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ade8f5cf-70f8-4659-a509-7e39b5b34d22

📥 Commits

Reviewing files that changed from the base of the PR and between c038795 and 5cbf65b.

📒 Files selected for processing (1)

• uninstall.sh

[wscurran]

✨ Thanks for submitting this PR that proposes a fix for the uninstall command not removing the NemoClaw CLI, which could help improve the uninstall process and is a good first issue for new contributors.

---

Possibly related open issues:

• #1959 [NemoClaw][All Platforms][Docs][Uninstall] curl bash uninstall didn't remove nemoclaw cli

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.