fix(inference): migrate GLM-5 model references to GLM-5.1 (#1744)#1990
fix(inference): migrate GLM-5 model references to GLM-5.1 (#1744)#1990cv merged 2 commits intoNVIDIA:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (8)
✅ Files skipped from review due to trivial changes (5)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis pull request updates the NVIDIA Endpoints curated model identifier from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
✨ Thanks for submitting this PR that proposes a fix and enhancement to the inference capabilities of NemoClaw by migrating GLM-5 model references to GLM-5.1, which could help ensure compatibility with the latest models. Possibly related open issues: |
6aeb15b to
334300d
Compare
Fixes NVIDIA#1744. GLM-5 is deprecated per NVIDIA API Catalog notice (Apr 9 – May 9, 2026 migration window; full shutdown May 9). The successor is GLM-5.1, which the catalog already serves at the same provider prefix. Swap every curated reference to the new model id and label: - src/lib/inference-config.ts — CLOUD_MODEL_OPTIONS picker entry - src/lib/inference-config.test.ts — id-list assertion - src/lib/inventory-commands.test.ts — sandbox-list fixtures - test/onboard-selection.test.ts — mocked /v1/models response - docs/inference/inference-options.md — NVIDIA Endpoints example list - docs/get-started/quickstart.md — NVIDIA Endpoints example list - .agents/skills/nemoclaw-user-configure-inference/references/ inference-options.md - .agents/skills/nemoclaw-user-get-started/SKILL.md No code-path changes. Users with existing sandboxes still pinned to z-ai/glm5 will need to rebuild during the migration window. Signed-off-by: ColinM-sys <cmcdonough@50words.com>
334300d to
bc932c0
Compare
## Summary Refreshes user-facing docs for the last 24 hours of merged NemoClaw history and bumps the docs metadata to 0.0.29, the next version after v0.0.28. The updates are limited to behavior supported by merged PR descriptions and diffs. ## Changes - `docs/reference/commands.md`: documented `nemoclaw <name> policy-add --from-file` and `--from-dir`, including custom preset review guidance, from #2077 / commit `7720b175`. - `docs/deployment/deploy-to-remote-gpu.md`: clarified that non-loopback `CHAT_UI_URL` disables OpenClaw device pairing for remote browser-only deployments, from #2449 / commit `f5ee8a4d`. - `docs/inference/inference-options.md`: documented provider-aware credential retry validation and the NVIDIA-only `nvapi-` prefix check, from #2389 / commit `6f7f0c6d`. - `docs/inference/switch-inference-providers.md`: documented `NEMOCLAW_INFERENCE_INPUTS` for text/image-capable model metadata baked into `openclaw.json`, from #2441 / commit `f4391892`. - `docs/reference/troubleshooting.md`: added the Git certificate verification entry for proxy CA propagation through `GIT_SSL_CAINFO`, `GIT_SSL_CAPATH`, `CURL_CA_BUNDLE`, and `REQUESTS_CA_BUNDLE`, from #2345 / commit `fa0dc1ab`. - `docs/versions1.json` and `docs/project.json`: promoted docs version `0.0.29`; `docs/versions1.json` omits unpublished `0.0.26`, `0.0.27`, and `0.0.28` entries. - `.agents/skills/nemoclaw-user-*`: regenerated derived user skill references from the updated docs. - Reviewed with no extra doc changes: #2575 / `d392ec07`, #2565 / `a3231049`, #1965 / `db1ef3ca`, #1990 / `db665834`, #2495 / `7da86fa3`, #2496 / `3192f4f4`, #2490 / `8c209058`, #2487 / `1f615e2f`, #2483 / `5653d33a`, #2482 / `31c782c0`, #2464 / `23bb5703`, #2472 / `a54f9a34`, and #2437 / `6bc860d7`. - Skipped per docs policy: #2420 / `7b76df6b` touched the experimental sandbox config path listed in `docs/.docs-skip`; #2466 / `cc15689c` touched a skipped term and CI-only sandbox image files. ## Type of Change - [ ] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [x] Doc only (includes code sample changes) ## Verification <!-- Check each item you ran and confirmed. Leave unchecked items you skipped. --> - [x] `npx prek run --all-files` passes - [ ] `npm test` passes — failed locally in installer-integration tests and one onboard helper timeout; the doc-scoped hook test projects passed under `prek`. - [ ] Tests added or updated for new or changed behavior - [x] No secrets, API keys, or credentials committed - [x] Docs updated for user-facing behavior changes - [ ] `make docs` builds without warnings (doc changes only) — build succeeded, but local Sphinx emitted the existing version-switcher file read message. - [x] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) ## AI Disclosure <!-- If an AI agent authored or co-authored this PR, check the box and name the tool. Remove this section for fully human-authored PRs. --> - [x] AI-assisted — tool: Codex --- <!-- DCO sign-off required by CI. Run: git config user.name && git config user.email --> Signed-off-by: Miyoung Choi <miyoungc@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Support for custom YAML presets in policy configuration via --from-file and --from-dir. * New build-time inference input option to declare accepted modalities (text or text,image). * **Improvements** * Credential validation now offers interactive recovery: re-enter key, retry, choose another provider, or exit. * Clarified provider-specific API key prefix handling (nvapi- only applies to NVIDIA keys). * **Documentation** * TLS certificate troubleshooting for inspected networks. * Clarified remote dashboard security/device-pairing behavior; command docs updated; docs version bumped. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Summary
Swap every curated
z-ai/glm5reference toz-ai/glm-5.1ahead of the May 9, 2026 full-deprecation date. The successor is already served at the same provider prefix, so this is a straight id/label rename.Fixes #1744.
Files changed
src/lib/inference-config.ts—CLOUD_MODEL_OPTIONSpicker entrysrc/lib/inference-config.test.ts— id-list assertionsrc/lib/inventory-commands.test.ts— sandbox-list fixturestest/onboard-selection.test.ts— mocked/v1/modelsresponse + selection answers + expected modeldocs/inference/inference-options.md— NVIDIA Endpoints example list.agents/skills/nemoclaw-user-configure-inference/SKILL.md.agents/skills/nemoclaw-user-configure-inference/references/inference-options.mdWhy now
Per the deprecation notice (issue #1744):
Landing this before May 9 ensures the curated picker and docs no longer suggest a model that will return hard errors post-T0.
Migration note for existing users
Users with sandboxes already pinned to
z-ai/glm5will keep working via the gateway redirect through the migration window. A rebuild after this PR lands will pick up the new default automatically.Test plan
npm run build:cli— cleannpx vitest run src/lib/inference-config.test.ts src/lib/inventory-commands.test.ts— 22/22 passglm5orGLM-5(pre-.1) references anywhere in the treeSigned-off-by: Colin McDonough cmcdonough@50words.com
Summary by CodeRabbit