Skip to content

fix(inference): migrate GLM-5 model references to GLM-5.1 (#1744)#1990

Merged
cv merged 2 commits intoNVIDIA:mainfrom
ColinM-sys:fix/1744-glm5-deprecation
Apr 27, 2026
Merged

fix(inference): migrate GLM-5 model references to GLM-5.1 (#1744)#1990
cv merged 2 commits intoNVIDIA:mainfrom
ColinM-sys:fix/1744-glm5-deprecation

Conversation

@ColinM-sys
Copy link
Copy Markdown
Contributor

@ColinM-sys ColinM-sys commented Apr 16, 2026

Summary

Swap every curated z-ai/glm5 reference to z-ai/glm-5.1 ahead of the May 9, 2026 full-deprecation date. The successor is already served at the same provider prefix, so this is a straight id/label rename.

Fixes #1744.

Files changed

  • src/lib/inference-config.tsCLOUD_MODEL_OPTIONS picker entry
  • src/lib/inference-config.test.ts — id-list assertion
  • src/lib/inventory-commands.test.ts — sandbox-list fixtures
  • test/onboard-selection.test.ts — mocked /v1/models response + selection answers + expected model
  • docs/inference/inference-options.md — NVIDIA Endpoints example list
  • .agents/skills/nemoclaw-user-configure-inference/SKILL.md
  • .agents/skills/nemoclaw-user-configure-inference/references/inference-options.md

Why now

Per the deprecation notice (issue #1744):

  • Apr 9, 2026 — Deprecation notice + banner live (gateway redirect active during migration window)
  • May 9, 2026 — GLM-5 fully shut down
  • Successor: GLM-5.1

Landing this before May 9 ensures the curated picker and docs no longer suggest a model that will return hard errors post-T0.

Migration note for existing users

Users with sandboxes already pinned to z-ai/glm5 will keep working via the gateway redirect through the migration window. A rebuild after this PR lands will pick up the new default automatically.

Test plan

  • npm run build:cli — clean
  • npx vitest run src/lib/inference-config.test.ts src/lib/inventory-commands.test.ts — 22/22 pass
  • No remaining glm5 or GLM-5 (pre-.1) references anywhere in the tree
  • No code-path changes — purely a string rename

Signed-off-by: Colin McDonough cmcdonough@50words.com

Summary by CodeRabbit

  • Updates
    • Replaced NVIDIA Endpoints curated model GLM-5 with GLM-5.1 across configuration, tests, onboarding/selection flows, documentation, and quickstart examples to keep model identifiers consistent.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2033de34-1a1d-4363-9046-507a5ff36f0c

📥 Commits

Reviewing files that changed from the base of the PR and between 334300d and bc932c0.

📒 Files selected for processing (8)
  • .agents/skills/nemoclaw-user-configure-inference/references/inference-options.md
  • .agents/skills/nemoclaw-user-get-started/SKILL.md
  • docs/get-started/quickstart.md
  • docs/inference/inference-options.md
  • src/lib/inference-config.test.ts
  • src/lib/inference-config.ts
  • src/lib/inventory-commands.test.ts
  • test/onboard-selection.test.ts
✅ Files skipped from review due to trivial changes (5)
  • src/lib/inference-config.test.ts
  • .agents/skills/nemoclaw-user-configure-inference/references/inference-options.md
  • docs/inference/inference-options.md
  • src/lib/inventory-commands.test.ts
  • test/onboard-selection.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/lib/inference-config.ts

📝 Walkthrough

Walkthrough

This pull request updates the NVIDIA Endpoints curated model identifier from z-ai/glm5 to z-ai/glm-5.1 across config, tests, onboarding, and docs. The code export CLOUD_MODEL_OPTIONS now uses id: "z-ai/glm-5.1" while the visible label remains GLM-5 in code; documentation examples were updated to GLM-5.1.

Changes

Cohort / File(s) Summary
Core config
src/lib/inference-config.ts
Replaced cloud model id z-ai/glm5 with z-ai/glm-5.1 in CLOUD_MODEL_OPTIONS (label in code kept as "GLM-5").
Config & inventory tests
src/lib/inference-config.test.ts, src/lib/inventory-commands.test.ts
Updated expected model id strings from z-ai/glm5 to z-ai/glm-5.1.
Onboarding tests
test/onboard-selection.test.ts
Mocked /v1/models response and assertions updated to use z-ai/glm-5.1.
Reference docs
.agents/skills/nemoclaw-user-configure-inference/references/inference-options.md, docs/inference/inference-options.md
Provider options table updated: curated model entry changed from GLM-5 to GLM-5.1.
User guidance / Quickstart
.agents/skills/nemoclaw-user-get-started/SKILL.md, docs/get-started/quickstart.md
Examples and onboarding wizard guidance updated to show GLM-5.1 in model selection lists.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A hop, a tweak, a tiny fix so neat,
IDs aligned and docs now sing complete.
GLM-5.1 trots in, a polite little bow,
Tests and guides agree — migration's done now. 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: migrating GLM-5 model references to GLM-5.1 across the codebase.
Linked Issues check ✅ Passed The PR fully satisfies issue #1744 requirements by replacing all GLM-5 references with GLM-5.1 in curated pickers, documentation, and test fixtures.
Out of Scope Changes check ✅ Passed All changes are scoped to updating GLM-5 to GLM-5.1 across documentation and code; no unrelated modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@wscurran wscurran added fix enhancement: inference Items related to running (local or hosted) inference models from NemoClaw. labels Apr 20, 2026
@wscurran
Copy link
Copy Markdown
Contributor

✨ Thanks for submitting this PR that proposes a fix and enhancement to the inference capabilities of NemoClaw by migrating GLM-5 model references to GLM-5.1, which could help ensure compatibility with the latest models.


Possibly related open issues:

@ColinM-sys ColinM-sys force-pushed the fix/1744-glm5-deprecation branch from 6aeb15b to 334300d Compare April 24, 2026 00:23
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 24, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Fixes NVIDIA#1744.

GLM-5 is deprecated per NVIDIA API Catalog notice (Apr 9 – May 9,
2026 migration window; full shutdown May 9). The successor is
GLM-5.1, which the catalog already serves at the same provider
prefix.

Swap every curated reference to the new model id and label:
- src/lib/inference-config.ts — CLOUD_MODEL_OPTIONS picker entry
- src/lib/inference-config.test.ts — id-list assertion
- src/lib/inventory-commands.test.ts — sandbox-list fixtures
- test/onboard-selection.test.ts — mocked /v1/models response
- docs/inference/inference-options.md — NVIDIA Endpoints example list
- docs/get-started/quickstart.md — NVIDIA Endpoints example list
- .agents/skills/nemoclaw-user-configure-inference/references/
  inference-options.md
- .agents/skills/nemoclaw-user-get-started/SKILL.md

No code-path changes. Users with existing sandboxes still pinned to
z-ai/glm5 will need to rebuild during the migration window.

Signed-off-by: ColinM-sys <cmcdonough@50words.com>
@ColinM-sys ColinM-sys force-pushed the fix/1744-glm5-deprecation branch from 334300d to bc932c0 Compare April 27, 2026 06:42
@cv cv merged commit db66583 into NVIDIA:main Apr 27, 2026
1 check passed
@miyoungc miyoungc mentioned this pull request Apr 28, 2026
13 tasks
miyoungc added a commit that referenced this pull request Apr 28, 2026
## Summary
Refreshes user-facing docs for the last 24 hours of merged NemoClaw
history and bumps the docs metadata to 0.0.29, the next version after
v0.0.28. The updates are limited to behavior supported by merged PR
descriptions and diffs.

## Changes
- `docs/reference/commands.md`: documented `nemoclaw <name> policy-add
--from-file` and `--from-dir`, including custom preset review guidance,
from #2077 / commit `7720b175`.
- `docs/deployment/deploy-to-remote-gpu.md`: clarified that non-loopback
`CHAT_UI_URL` disables OpenClaw device pairing for remote browser-only
deployments, from #2449 / commit `f5ee8a4d`.
- `docs/inference/inference-options.md`: documented provider-aware
credential retry validation and the NVIDIA-only `nvapi-` prefix check,
from #2389 / commit `6f7f0c6d`.
- `docs/inference/switch-inference-providers.md`: documented
`NEMOCLAW_INFERENCE_INPUTS` for text/image-capable model metadata baked
into `openclaw.json`, from #2441 / commit `f4391892`.
- `docs/reference/troubleshooting.md`: added the Git certificate
verification entry for proxy CA propagation through `GIT_SSL_CAINFO`,
`GIT_SSL_CAPATH`, `CURL_CA_BUNDLE`, and `REQUESTS_CA_BUNDLE`, from #2345
/ commit `fa0dc1ab`.
- `docs/versions1.json` and `docs/project.json`: promoted docs version
`0.0.29`; `docs/versions1.json` omits unpublished `0.0.26`, `0.0.27`,
and `0.0.28` entries.
- `.agents/skills/nemoclaw-user-*`: regenerated derived user skill
references from the updated docs.
- Reviewed with no extra doc changes: #2575 / `d392ec07`, #2565 /
`a3231049`, #1965 / `db1ef3ca`, #1990 / `db665834`, #2495 / `7da86fa3`,
#2496 / `3192f4f4`, #2490 / `8c209058`, #2487 / `1f615e2f`, #2483 /
`5653d33a`, #2482 / `31c782c0`, #2464 / `23bb5703`, #2472 / `a54f9a34`,
and #2437 / `6bc860d7`.
- Skipped per docs policy: #2420 / `7b76df6b` touched the experimental
sandbox config path listed in `docs/.docs-skip`; #2466 / `cc15689c`
touched a skipped term and CI-only sandbox image files.

## Type of Change
- [ ] Code change (feature, bug fix, or refactor)
- [ ] Code change with doc updates
- [ ] Doc only (prose changes, no code sample modifications)
- [x] Doc only (includes code sample changes)

## Verification
<!-- Check each item you ran and confirmed. Leave unchecked items you
skipped. -->
- [x] `npx prek run --all-files` passes
- [ ] `npm test` passes — failed locally in installer-integration tests
and one onboard helper timeout; the doc-scoped hook test projects passed
under `prek`.
- [ ] Tests added or updated for new or changed behavior
- [x] No secrets, API keys, or credentials committed
- [x] Docs updated for user-facing behavior changes
- [ ] `make docs` builds without warnings (doc changes only) — build
succeeded, but local Sphinx emitted the existing version-switcher file
read message.
- [x] Doc pages follow the [style
guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md)
(doc changes only)
- [ ] New doc pages include SPDX header and frontmatter (new pages only)

## AI Disclosure
<!-- If an AI agent authored or co-authored this PR, check the box and
name the tool. Remove this section for fully human-authored PRs. -->
- [x] AI-assisted — tool: Codex

---
<!-- DCO sign-off required by CI. Run: git config user.name && git
config user.email -->
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Support for custom YAML presets in policy configuration via
--from-file and --from-dir.
* New build-time inference input option to declare accepted modalities
(text or text,image).

* **Improvements**
* Credential validation now offers interactive recovery: re-enter key,
retry, choose another provider, or exit.
* Clarified provider-specific API key prefix handling (nvapi- only
applies to NVIDIA keys).

* **Documentation**
  * TLS certificate troubleshooting for inspected networks.
* Clarified remote dashboard security/device-pairing behavior; command
docs updated; docs version bumped.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement: inference Items related to running (local or hosted) inference models from NemoClaw. fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Model Deprecation – [API Catalog] [glm5] [10 Days Notice]

3 participants