fix(test): restore port-resolution assertions in nimStatusByName tests

[laitingsheng]

Summary

Restore the curl-URL assertions in two nimStatusByName tests so they actually verify the port-resolution logic instead of only the boolean health result.

Related Issue

Closes #1280

Changes

• src/lib/nim.test.ts:
  • "uses published docker port when no port is provided" — assert the curl call used http://127.0.0.1:9000/v1/models.
  • "falls back to 8000 when docker port lookup fails" — assert the curl call used http://127.0.0.1:8000/v1/models.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Verification

• npx prek run --all-files passes
• npm test passes
• Tests added or updated for new or changed behavior
• No secrets, API keys, or credentials committed
• Docs updated for user-facing behavior changes
• make docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: Tinson Lai tinsonl@nvidia.com

Summary by CodeRabbit

• Tests
  • Enhanced test coverage for health-probe verification scenarios to ensure proper command execution validation.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b38e4e3e-65a5-4a2f-ba57-317cb2f19d3a

📥 Commits

Reviewing files that changed from the base of the PR and between 2c3a392 and c968e89.

📒 Files selected for processing (1)

• src/lib/nim.test.ts

---

📝 Walkthrough

Walkthrough

This PR restores health-probe URL assertions in the nimStatusByName test suite. Two test scenarios now verify that curl commands target the correct port-resolved localhost URLs using substring matching via commands.some(...), confirming the port-resolution branching logic is exercised correctly.

Changes

Health Probe URL Assertions

Layer / File(s)	Summary
Health Probe URL Assertions src/lib/nim.test.ts	"uses published docker port when no port is provided" test asserts that at least one recorded command contains http://127.0.0.1:9000/v1/models using commands.some(...). "falls back to 8000 when docker port lookup fails" test similarly asserts presence of http://127.0.0.1:8000/v1/models among recorded commands while preserving docker port invocation verification.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hops through test assertions bright,
Where curl commands now target ports just right—
Nine-thousand here, eight-thousand there,
Port resolution answers to our care! 🐰✓

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: restoring port-resolution assertions in specific tests.
Linked Issues check	✅ Passed	The PR addresses the requirements from issue #1280 by restoring curl URL assertions for both port-resolution test scenarios.
Out of Scope Changes check	✅ Passed	All changes are directly related to restoring assertions in the nimStatusByName tests as specified in issue #1280.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/issue-1280-nim-port-resolution-assertions

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Microsoft Presidio Analyzer (2.2.362)

src/lib/nim.test.ts

Microsoft Presidio Analyzer failed to scan this file

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}