fix(onboard): resolve moved Ollama lazy-load path

[fallintoplace]

Summary

• resolve the moved onboard lazy-load path inside the Ollama tools-capability gate
• restore access to onboard-backed nonInteractive state and the shared prompt helper after the #3195 file move
• add regression coverage for onboard-backed non-interactive and prompt-helper paths

Root cause

#3195 moved src/lib/onboard-ollama-proxy.ts to src/lib/inference/ollama/proxy.ts, but the lazy-load sites kept require("./onboard").

That path was correct in the old location, but from src/lib/inference/ollama/proxy.ts it resolves to a nonexistent sibling module instead of src/lib/onboard.ts. The catch blocks then silently fall back to env vars only.

Scope

This change keeps the fix narrow and only repairs the moved-module path regression plus the missing regression coverage.

It does not expand the in-memory autoYes behavior, since isAutoYes is not currently exported from src/lib/onboard.ts and would be a separate scope decision.

Testing

• npm run build:cli
• npm test -- test/ollama-tools-capability.test.ts

Fixes #4139

Summary by CodeRabbit

• Chores

  • Updated internal module loading patterns.

• Tests

  • Enhanced test infrastructure and expanded test coverage for proxy configuration scenarios.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c0cc5f84-b625-4a5d-88b2-165a65f0c0c7

📥 Commits

Reviewing files that changed from the base of the PR and between de3b9ba and a16be7f.

📒 Files selected for processing (2)

• src/lib/inference/ollama/proxy.ts
• test/ollama-tools-capability.test.ts

---

📝 Walkthrough

Walkthrough

Two files were updated to fix a regression where the Ollama tools-capability gate lost access to onboard module state after a directory refactor. The relative require paths are corrected from ./onboard to ../../onboard, and test harness infrastructure is extended to stub onboard exports and validate the fix with new test coverage.

Changes

Ollama tools-capability gate onboard access restoration

Layer / File(s)	Summary
Path correction in proxy.ts src/lib/inference/ollama/proxy.ts	Three lazy-require call sites (isProxyNonInteractive, isProxyAutoYes, promptProxyYesNo) update their relative paths from ./onboard to ../../onboard to correctly resolve the onboard module from its new location.
Test harness onboard stubbing infrastructure test/ollama-tools-capability.test.ts	Expands the proxy test harness to capture, stub, and restore the onboard module's cached entry, introducing OnboardModuleExports interface, a setOnboardExports() setter, and helpers to manipulate the require-cache state during test setup/teardown.
Test cases for onboard export behavior test/ollama-tools-capability.test.ts	Adds two new test cases: one verifying that the gate respects onboard isNonInteractive export state and blocks without prompting, and another verifying that the gate uses onboard's promptYesNoOrDefault export when available instead of the local fallback.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Suggested labels

bug, NemoClaw CLI, fix

Suggested reviewers

• ericksoa
• cv

Poem

🐰 Three paths were lost in the module maze,
Where onboard light no longer plays,
A fix hops in—../../ shows the way,
Tests guard the gate through night and day. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 11.11% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately reflects the main change: fixing the lazy-load path for the relocated onboard module in the Ollama proxy.
Linked Issues check	✅ Passed	The PR directly addresses all coding objectives from issue #4139: correcting the lazy require path from './onboard' to '../../onboard', ensuring access to onboard module state for nonInteractive and prompt helper, and adding regression test coverage.
Out of Scope Changes check	✅ Passed	All changes are within scope: path corrections in proxy.ts and test infrastructure/coverage additions in the test file align with the stated narrow fix and regression testing objectives.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[wscurran]

✨ Thanks for submitting this detailed PR about resolving the moved onboard lazy-load path inside the Ollama tools-capability gate. This proposes a fix for the regression caused by the file move in #3195 and adds regression coverage for onboard-backed non-interactive and prompt-helper paths.

---

Related open PRs:

• #3195 refactor(cli): group inference and onboard support modules

---

Related open issues:

• #4139 Ollama tools-capability gate still lazy-loads ./onboard after #3195 move and misses onboard non-interactive state

[cv]

Thanks for identifying the moved-path regression and establishing the initial regression-test direction here. #5898 is a fresh replacement because this branch now conflicts with main and its unsigned published commit cannot be rewritten under the repository's current verification policy. The replacement preserves the issue intent while removing the Ollama proxy's onboarding dependency entirely through an explicit interaction boundary. Please continue review on #5898.

[fallintoplace]

I am glad this issue is fixed. @cv

Feel free to close or amend this PR.

[apurvvkumaria]

Closing as superseded by #5898, which merged as 2330e39552b0405345c1777883f4f6dacef24105 and closed #4139.

There is no remaining gap on current main (fed46043459497011c65884720cb24a354cfb2bb):

• proxy.ts lines 777-798 define the injected non-interactive, auto-yes, and confirmation boundary plus standalone defaults, with no lazy dependency on onboard.ts.
• proxy.ts lines 811-865 consume that boundary for auto-yes, non-interactive override/blocking, and interactive confirmation.
• onboard.ts lines 3099-3101 and 3147 inject the live onboarding state into prepareOllamaModel() explicitly.
• ollama-tools-capability.test.ts lines 430-512 cover caller-supplied non-interactive state, auto-yes without prompting, delegated confirmation, and preparation-path propagation.

That explicit interaction boundary supersedes this PR's path-only change in a07b5c29deea1404243bfc03bb65cfde42bfeaf8. This branch is also conflicting; that first commit is unsigned/unverified and has no sign-off, while the later verified merge commit does not repair its history and the PR body has no DCO declaration.

Thank you @fallintoplace for the original moved-path diagnosis and regression-test direction. #5898 explicitly preserved and credited that contribution, and your follow-up here confirmed that this PR may be closed.