fix(policy): keep preset descriptions line-scoped (Fixes #4312)

[deepujain]

Summary

Fixes #4312.

policy-list was reading preset descriptions with a regex that could keep matching into the rest of the YAML body. The WhatsApp preset then showed part of network_policies as if it were description text.

Changes

• Keep preset description parsing scoped to a single line in src/lib/policy/index.ts.
• Quote the WhatsApp preset description in nemoclaw-blueprint/policies/presets/whatsapp.yaml.
• Add a regression test that checks the WhatsApp description is exact and does not include the YAML body.

Testing

• npm run build:cli
• npm run typecheck:cli
• npx vitest run test/policies.test.ts
• npm test -- test/policies.test.ts

The focused policy suite passes with 152/152 tests.

Signed-off-by: Deepak Jain deepujain@gmail.com

Summary by CodeRabbit

• Bug Fixes

  • Preset descriptions now render exactly as intended; stray YAML markers no longer appear.
  • WhatsApp preset description normalized for consistent display and robust parsing to prevent spillover into the YAML body.

• Tests

  • Added tests to validate preset description parsing and prevent regressions.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f458920d-1407-4eae-9ae6-669dc17b78e3

📥 Commits

Reviewing files that changed from the base of the PR and between 07fd452 and e5735f7.

📒 Files selected for processing (1)

• nemoclaw-blueprint/policies/presets/whatsapp.yaml

💤 Files with no reviewable changes (1)

• nemoclaw-blueprint/policies/presets/whatsapp.yaml

---

📝 Walkthrough

Walkthrough

Updates the preset description extraction to use a line-scoped regex, quotes the WhatsApp preset's description in the blueprint, and adds a test asserting the parsed description is the single-line human-readable string (no YAML body).

Changes

Preset description parser fix

Layer / File(s)	Summary
Regex update, WhatsApp preset quoting, and regression test src/lib/policy/index.ts, nemoclaw-blueprint/policies/presets/whatsapp.yaml, test/policies.test.ts	listPresets() now uses a line-scoped regex to extract description: values. The WhatsApp preset's preset.description is converted to a quoted string. A new test verifies the parsed description equals the expected human-readable text and does not include the YAML network_policies: body.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

v0.0.58

Suggested reviewers

• prekshivyas

Poem

🐰 I hopped through files with nimble paws,
found a regex eating extra claus.
We boxed the words and made them neat,
now presets list tidy, short, and sweet. 🥕

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title clearly summarizes the main fix: making preset descriptions line-scoped to prevent regex greedy capture, directly addressing issue #4312.
Linked Issues check	✅ Passed	The PR fully implements both suggested fixes from #4312: hardening the regex with stricter character class [^\\n]* and quoting the WhatsApp preset description.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to resolving issue #4312: regex fix, preset quoting, and regression test. No unrelated modifications present.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[wscurran]

✨ Thanks for submitting this detailed PR that fixes the preset description parsing issue. This proposes a fix for the bug reported in #4312 and updates the policy-list to keep preset descriptions line-scoped.

---

Related open issues:

• #4312 [Ubuntu 24.04][CLI&UX] policy-list output appends spurious whatsapp YAML body to last preset's description (regex parser greedy-captures unquoted description)

[deepujain]

Rebased on current main. build:cli and the focused policy description parser tests pass.

[deepujain]

Rebased onto current main and kept this as a clean signed one-commit stack. build:cli and the focused policy description parser tests pass.