fix(cli): align list default sandbox with env overrides (#1077)

[Thabhelo]

Summary

Follow-up to #4756 / #1077: nemoclaw list and inventory JSON now resolve the default sandbox from SANDBOX_NAME / NEMOCLAW_SANDBOX_NAME / NEMOCLAW_SANDBOX, matching status, start, and stop. Also consolidates #1077 test env isolation into shared beforeEach/afterEach hooks.

Related Issue

Related to #1077 (follow-up to merged #4756)

Changes

• Wire resolveDefaultSandboxName() into getSandboxInventory() for defaultSandbox and isDefault rows
• Add list/inventory tests for env-resolved default sandbox marker (*)
• Refactor #1077 inventory tests into a nested describe with shared env save/restore
• Add beforeEach env clearing in services.test.ts #1077 describe block

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Verification

• npx prek run --all-files passes
• npm test passes (targeted: src/lib/inventory/index.test.ts, src/lib/tunnel/services.test.ts, including -t '#1077')
• Tests added or updated for new or changed behavior
• No secrets, API keys, or credentials committed
• Docs updated for user-facing behavior changes
• npm run docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: Thabhelo 50872400+Thabhelo@users.noreply.github.com

Summary by CodeRabbit

• Tests

  • Improved test organization and environment variable cleanup for better test reliability.

• Refactor

  • Enhanced internal sandbox resolution logic for improved consistency.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[coderabbitai]

Wondering what really moved? Review this PR in Change Stack to inspect semantic changes, definitions, and references.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ced5aa94-a273-4108-ab54-460735364a3c

📥 Commits

Reviewing files that changed from the base of the PR and between 9b16a9e and 0e7f98a.

📒 Files selected for processing (3)

• src/lib/inventory/index.test.ts
• src/lib/inventory/index.ts
• src/lib/tunnel/services.test.ts

---

📝 Walkthrough

Walkthrough

This PR implements environment-variable-driven default sandbox resolution in the inventory service by replacing direct default access with resolveDefaultSandboxName(), consolidates environment cleanup in test suites using shared lifecycle hooks, and adds comprehensive coverage for sandbox selection via SANDBOX_NAME and NEMOCLAW_SANDBOX_NAME environment variables.

Changes

Default Sandbox Resolution and Test Consolidation

Layer / File(s)	Summary
Default sandbox resolution implementation src/lib/inventory/index.ts	getSandboxInventory derives defaultSandbox via resolveDefaultSandboxName() instead of using recovery.defaultSandbox directly, and the inventory result and row construction now use this resolved value.
Inventory test environment lifecycle and coverage src/lib/inventory/index.test.ts	Test imports add afterEach; a new describe("#1077 — env-resolved default sandbox") block captures, clears, and restores SANDBOX_NAME, NEMOCLAW_SANDBOX_NAME, and NEMOCLAW_SANDBOX in shared beforeEach/afterEach hooks. Tests cover sandbox resolution from SANDBOX_NAME env, JSON status resolution from NEMOCLAW_SANDBOX_NAME env, and list output formatting (marking the env-resolved sandbox with * and not marking the registry default).
Tunnel service test environment consolidation src/lib/tunnel/services.test.ts	The #1077 test suite moves per-test environment variable cleanup into a shared beforeEach hook, removing redundant inline deletions of SANDBOX_NAME, NEMOCLAW_SANDBOX, and NEMOCLAW_SANDBOX_NAME from three individual test cases.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• NVIDIA/NemoClaw#4756: Both PRs target sandbox env/default selection for #1077 status flows—this PR refactors env setup/teardown and adds resolution coverage while the related PR may introduce or refine the resolveDefaultSandboxName function.

Suggested labels

NemoClaw CLI, fix, area: cli, bug-fix, v0.0.60

Suggested reviewers

• prekshivyas
• cv

Poem

🐰 The sandbox chose its way,
Via env variables that sway,
Tests now share their cleanup chore,
No duplication anymore,
Resolution blooms—hooray, hooray!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately captures the main change: aligning the list command's default sandbox resolution with environment variable overrides, which is the core objective of this fix.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Thabhelo]

@prekshivyas — follow-up on your non-blocking review notes from #4756.