docs: update host files and state reference - #6605
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe host-state reference updates descriptions of shared and sandbox-local state, strengthens sensitive-data warnings, revises ChangesHost state documentation
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
🌿 Preview your docs: https://nvidia-preview-pr-6605.docs.buildwithfern.com/nemoclaw |
PR Review Advisor — No blocking findingsMerge posture: No blocking advisor findings Action checklist
Test follow-ups to resolve or justifyIf these cover changed behavior, prefer adding them in this PR; otherwise state why existing coverage is enough or link the follow-up.
This is an automated, non-binding review; it still expects maintainers and agents to respond to each required or warning item. Treat suggestions as current-PR improvements when they touch changed code; defer only with maintainer rationale or a linked follow-up. A human maintainer must make the final merge decision. |
PR Review Advisor (Nemotron Ultra) — No blocking findingsMerge posture: No blocking advisor findings This is an automated, non-binding review; it still expects maintainers and agents to respond to each required or warning item. Treat suggestions as current-PR improvements when they touch changed code; defer only with maintainer rationale or a linked follow-up. A human maintainer must make the final merge decision. |
E2E Advisor RecommendationRequired E2E: None Full advisor summaryE2E Recommendation AdvisorFailed: Advisor SDK provider error: session: 429 status code (no body); turn: analysis: 429 status code (no body) |
E2E Target RecommendationRequired E2E targets: None Full E2E target advisor summaryE2E Target AdvisorBase: Required E2E targets
Optional E2E targets
Relevant changed files
|
|
PRA-1 justification: both PR Review Advisor backends failed before analysis because their SDK sessions received upstream HTTP 429 responses in workflow run 29050227437. Neither backend produced a file-specific finding. The one-file documentation diff received a manual source-to-doc review against issue #6555 and the current credential migration, usage-notice, and operational-state implementations. A second scoped documentation review corrected precision before the final build. CodeRabbit reported no actionable comments, the focused credential and notice tests pass (3 files, 52 tests), and all required CI, CodeQL, docs-only, and image checks are green. No branch change is appropriate for this advisor infrastructure failure; final maintainer review remains required. |
<!-- markdownlint-disable MD041 --> ## Summary <!-- 1-3 sentences: what this PR does and why. --> Updates the host-files reference to match current credential and state behavior. It marks `credentials.json` as a legacy migration artifact and documents `usage-notice.json` and the operational `state/` directory. ## Related Issue <!-- Fixes #NNN or Closes #NNN. Remove this section if none. --> Closes NVIDIA#6555 ## Changes <!-- Bullet list of key changes. --> - Clarify that current releases register provider credentials with the OpenShell gateway and do not create `~/.nemoclaw/credentials.json`. - Document the accepted-version record in `~/.nemoclaw/usage-notice.json` and its deletion behavior. - Document the operational coordination and history stored under `~/.nemoclaw/state/`. ## Type of Change - [ ] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [x] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Quality Gates <!-- Check exactly one tests line and one docs line. Check other lines when applicable. Add every requested justification or approval reference. --> - [ ] Tests added or updated for changed behavior - [x] Existing tests cover changed behavior — justification: 52 focused credential migration and usage-notice tests pass across the integration, CLI, and package-contract projects. - [ ] Tests not applicable — justification: - [x] Docs updated for user-facing behavior changes - [ ] Docs not applicable — justification: - [ ] Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging) - [ ] Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: - [ ] Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue: ## Verification <!-- Check each applicable item only when supported by the requested evidence. Run targeted tests once per relevant change set and rerun after later edits or hook autofixes that can affect the tested behavior. Do not rerun hook-covered checks. --> - [x] PR description includes the DCO sign-off declaration and every commit appears as `Verified` in GitHub - [x] Normal `pre-commit`, `commit-msg`, and `pre-push` hooks passed, or `npm run check:diff` passed when hooks were skipped or unavailable - [x] Targeted behavior tests pass for the current change set, or tests are marked not applicable above — command/result or justification: `npx vitest run --project cli --project integration --project package-contract src/lib/actions/sandbox/rebuild-usage-notice.test.ts test/credentials.test.ts test/package-contract/onboard/usage-notice.test.ts` passed, 3 files and 52 tests. - [ ] Applicable broad gate passed — `npm test` for broad runtime/test-harness changes; `npm run check` for repo-wide validation/coverage changes — command/result: - [x] Quality Gates section completed with required justifications or waivers - [x] No secrets, API keys, or credentials committed - [ ] `npm run docs` builds without warnings (doc changes only) — result: passed with 0 errors; Fern reports the existing repository theme accent-color contrast warning. - [x] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) --- <!-- DCO sign-off is required in this PR description, and every commit must appear as Verified in GitHub. Run: git config user.name && git config user.email --> Signed-off-by: Miyoung Choi <miyoungc@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Clarified the host-state reference for files stored under `~/.nemoclaw/`. * Updated guidance for legacy credential data, including safer handling and migration instructions. * Added clearer notes for `usage-notice.json` and other host JSON files, including whether they can be deleted. * Documented the `~/.nemoclaw/state/` directory and its role in storing operational history and coordination data. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Summary
Updates the host-files reference to match current credential and state behavior.
It marks
credentials.jsonas a legacy migration artifact and documentsusage-notice.jsonand the operationalstate/directory.Related Issue
Closes #6555
Changes
~/.nemoclaw/credentials.json.~/.nemoclaw/usage-notice.jsonand its deletion behavior.~/.nemoclaw/state/.Type of Change
Quality Gates
Verification
Verifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run check:diffpassed when hooks were skipped or unavailablenpx vitest run --project cli --project integration --project package-contract src/lib/actions/sandbox/rebuild-usage-notice.test.ts test/credentials.test.ts test/package-contract/onboard/usage-notice.test.tspassed, 3 files and 52 tests.npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result:npm run docsbuilds without warnings (doc changes only) — result: passed with 0 errors; Fern reports the existing repository theme accent-color contrast warning.Signed-off-by: Miyoung Choi miyoungc@nvidia.com
Summary by CodeRabbit
~/.nemoclaw/.usage-notice.jsonand other host JSON files, including whether they can be deleted.~/.nemoclaw/state/directory and its role in storing operational history and coordination data.