Skip to content

docs: update host files and state reference - #6605

Merged
cv merged 1 commit into
mainfrom
codex/docs-host-files-state-6555
Jul 9, 2026
Merged

docs: update host files and state reference#6605
cv merged 1 commit into
mainfrom
codex/docs-host-files-state-6555

Conversation

@miyoungc

@miyoungc miyoungc commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

Updates the host-files reference to match current credential and state behavior.
It marks credentials.json as a legacy migration artifact and documents usage-notice.json and the operational state/ directory.

Related Issue

Closes #6555

Changes

  • Clarify that current releases register provider credentials with the OpenShell gateway and do not create ~/.nemoclaw/credentials.json.
  • Document the accepted-version record in ~/.nemoclaw/usage-notice.json and its deletion behavior.
  • Document the operational coordination and history stored under ~/.nemoclaw/state/.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Quality Gates

  • Tests added or updated for changed behavior
  • Existing tests cover changed behavior — justification: 52 focused credential migration and usage-notice tests pass across the integration, CLI, and package-contract projects.
  • Tests not applicable — justification:
  • Docs updated for user-facing behavior changes
  • Docs not applicable — justification:
  • Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
  • Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification:
  • Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Verification

  • PR description includes the DCO sign-off declaration and every commit appears as Verified in GitHub
  • Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run check:diff passed when hooks were skipped or unavailable
  • Targeted behavior tests pass for the current change set, or tests are marked not applicable above — command/result or justification: npx vitest run --project cli --project integration --project package-contract src/lib/actions/sandbox/rebuild-usage-notice.test.ts test/credentials.test.ts test/package-contract/onboard/usage-notice.test.ts passed, 3 files and 52 tests.
  • Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result:
  • Quality Gates section completed with required justifications or waivers
  • No secrets, API keys, or credentials committed
  • npm run docs builds without warnings (doc changes only) — result: passed with 0 errors; Fern reports the existing repository theme accent-color contrast warning.
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Miyoung Choi miyoungc@nvidia.com

Summary by CodeRabbit

  • Documentation
    • Clarified the host-state reference for files stored under ~/.nemoclaw/.
    • Updated guidance for legacy credential data, including safer handling and migration instructions.
    • Added clearer notes for usage-notice.json and other host JSON files, including whether they can be deleted.
    • Documented the ~/.nemoclaw/state/ directory and its role in storing operational history and coordination data.

@miyoungc miyoungc added the area: docs Documentation, examples, guides, or docs build label Jul 9, 2026
@miyoungc miyoungc self-assigned this Jul 9, 2026
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 8256ed08-d295-43c3-a2ef-0b93e82ae3b7

📥 Commits

Reviewing files that changed from the base of the PR and between 614122b and 59969ff.

📒 Files selected for processing (1)
  • docs/reference/host-files-and-state.mdx

📝 Walkthrough

Walkthrough

The host-state reference updates descriptions of shared and sandbox-local state, strengthens sensitive-data warnings, revises credentials.json and usage-notice.json guidance, and documents ~/.nemoclaw/state/.

Changes

Host state documentation

Layer / File(s) Summary
Update host files and state reference
docs/reference/host-files-and-state.mdx
Revises page metadata and Deep Agents guidance, broadens warnings for sensitive legacy artifacts, updates credentials.json and usage-notice.json entries, and documents the non-deletable ~/.nemoclaw/state/ directory.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main doc update to the host files and state reference.
Linked Issues check ✅ Passed The docs now cover the undocumented credentials.json, usage-notice.json, and state/ behavior requested in #6555.
Out of Scope Changes check ✅ Passed The added guidance stays within the host-files/state documentation scope and matches the issue objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/docs-host-files-state-6555

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor — No blocking findings

Merge posture: No blocking advisor findings
Primary next action: Add or justify PRA-T1 and any related test follow-ups.
Open items: 0 required · 0 warnings · 0 suggestions · 1 test follow-up

Action checklist

  • PRA-T1 Add or justify test follow-up: Acceptance clause
Test follow-ups to resolve or justify

If these cover changed behavior, prefer adding them in this PR; otherwise state why existing coverage is enough or link the follow-up.

  • PRA-T1 Acceptance clause — See NVBug for full reproduction steps and environment details. — add test evidence or identify existing coverage. The linked GitHub issue body contains only this sentence and no comments were returned by the context tool; NVBug content is not available in the repository context. The visible GitHub issue title clauses are covered by the documentation diff.

Workflow run details

This is an automated, non-binding review; it still expects maintainers and agents to respond to each required or warning item. Treat suggestions as current-PR improvements when they touch changed code; defer only with maintainer rationale or a linked follow-up. A human maintainer must make the final merge decision.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor (Nemotron Ultra) — No blocking findings

Merge posture: No blocking advisor findings
Primary next action: No advisor follow-up required beyond maintainer review.
Open items: 0 required · 0 warnings · 0 suggestions · 0 test follow-ups
Since last review: 0 prior items resolved · 0 still apply · 0 new items found

Workflow run details

This is an automated, non-binding review; it still expects maintainers and agents to respond to each required or warning item. Treat suggestions as current-PR improvements when they touch changed code; defer only with maintainer rationale or a linked follow-up. A human maintainer must make the final merge decision.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

E2E Advisor Recommendation

Required E2E: None
Optional E2E: None

Workflow run

Full advisor summary

E2E Recommendation Advisor

Failed: Advisor SDK provider error: session: 429 status code (no body); turn: analysis: 429 status code (no body)

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

E2E Target Recommendation

Required E2E targets: None
Optional E2E targets: None

Workflow run

Full E2E target advisor summary

E2E Target Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required E2E targets

  • None. Docs-only change outside E2E target-relevant paths; no E2E target dispatch is required.

Optional E2E targets

  • None.

Relevant changed files

  • None.

@miyoungc

miyoungc commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator Author

PRA-1 justification: both PR Review Advisor backends failed before analysis because their SDK sessions received upstream HTTP 429 responses in workflow run 29050227437. Neither backend produced a file-specific finding.

The one-file documentation diff received a manual source-to-doc review against issue #6555 and the current credential migration, usage-notice, and operational-state implementations. A second scoped documentation review corrected precision before the final build. CodeRabbit reported no actionable comments, the focused credential and notice tests pass (3 files, 52 tests), and all required CI, CodeQL, docs-only, and image checks are green. No branch change is appropriate for this advisor infrastructure failure; final maintainer review remains required.

@cv
cv merged commit e05536c into main Jul 9, 2026
43 of 49 checks passed
@cv
cv deleted the codex/docs-host-files-state-6555 branch July 9, 2026 21:42
Hadar301 pushed a commit to Hadar301/NemoClaw-OpenShift that referenced this pull request Jul 12, 2026
<!-- markdownlint-disable MD041 -->
## Summary
<!-- 1-3 sentences: what this PR does and why. -->
Updates the host-files reference to match current credential and state
behavior.
It marks `credentials.json` as a legacy migration artifact and documents
`usage-notice.json` and the operational `state/` directory.

## Related Issue
<!-- Fixes #NNN or Closes #NNN. Remove this section if none. -->
Closes NVIDIA#6555

## Changes
<!-- Bullet list of key changes. -->

- Clarify that current releases register provider credentials with the
OpenShell gateway and do not create `~/.nemoclaw/credentials.json`.
- Document the accepted-version record in
`~/.nemoclaw/usage-notice.json` and its deletion behavior.
- Document the operational coordination and history stored under
`~/.nemoclaw/state/`.

## Type of Change

- [ ] Code change (feature, bug fix, or refactor)
- [ ] Code change with doc updates
- [x] Doc only (prose changes, no code sample modifications)
- [ ] Doc only (includes code sample changes)

## Quality Gates
<!-- Check exactly one tests line and one docs line. Check other lines
when applicable. Add every requested justification or approval
reference. -->
- [ ] Tests added or updated for changed behavior
- [x] Existing tests cover changed behavior — justification: 52 focused
credential migration and usage-notice tests pass across the integration,
CLI, and package-contract projects.
- [ ] Tests not applicable — justification:
- [x] Docs updated for user-facing behavior changes
- [ ] Docs not applicable — justification:
- [ ] Sensitive paths changed (security, policy, credentials, preflight,
onboarding, inference, runner, sandbox, or messaging)
- [ ] Sensitive-path review completed or maintainer-approved waiver
recorded — reviewer/approval link/justification:
- [ ] Non-success, skipped, or missing CI check accepted by maintainer —
check name, approval link, and follow-up issue:

## Verification
<!-- Check each applicable item only when supported by the requested
evidence. Run targeted tests once per relevant change set and rerun
after later edits or hook autofixes that can affect the tested behavior.
Do not rerun hook-covered checks. -->
- [x] PR description includes the DCO sign-off declaration and every
commit appears as `Verified` in GitHub
- [x] Normal `pre-commit`, `commit-msg`, and `pre-push` hooks passed, or
`npm run check:diff` passed when hooks were skipped or unavailable
- [x] Targeted behavior tests pass for the current change set, or tests
are marked not applicable above — command/result or justification: `npx
vitest run --project cli --project integration --project
package-contract src/lib/actions/sandbox/rebuild-usage-notice.test.ts
test/credentials.test.ts
test/package-contract/onboard/usage-notice.test.ts` passed, 3 files and
52 tests.
- [ ] Applicable broad gate passed — `npm test` for broad
runtime/test-harness changes; `npm run check` for repo-wide
validation/coverage changes — command/result:
- [x] Quality Gates section completed with required justifications or
waivers
- [x] No secrets, API keys, or credentials committed
- [ ] `npm run docs` builds without warnings (doc changes only) —
result: passed with 0 errors; Fern reports the existing repository theme
accent-color contrast warning.
- [x] Doc pages follow the [style
guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md)
(doc changes only)
- [ ] New doc pages include SPDX header and frontmatter (new pages only)

---
<!-- DCO sign-off is required in this PR description, and every commit
must appear as Verified in GitHub. Run: git config user.name && git
config user.email -->
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Documentation**
* Clarified the host-state reference for files stored under
`~/.nemoclaw/`.
* Updated guidance for legacy credential data, including safer handling
and migration instructions.
* Added clearer notes for `usage-notice.json` and other host JSON files,
including whether they can be deleted.
* Documented the `~/.nemoclaw/state/` directory and its role in storing
operational history and coordination data.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: docs Documentation, examples, guides, or docs build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[All Platforms][Docs] host-files-and-state page: credentials.json no longer created in v0.0.78; state/ and usage-notice.json undocumented

3 participants