fix(onboard): remove doubled "and" in license acceptance prompt (#7301)

[jason-ma-nv]

Summary

The license / third-party software acceptance prompt read "the NemoClaw license
and and third-party software notice", repeating "and". The text is served from a
single shared data field, so the doubled conjunction appeared in both the
curl|bash installer and nemoclaw onboard on every platform. This removes the
duplicate word.

Related Issue

Fixes #7301

Changes

• Fixed interactivePrompt in bin/lib/usage-notice.json: "license and and
  third-party" → "license and third-party". This one field is consumed by
  scripts/install.sh (installer) and src/lib/onboard/usage-notice.ts
  (loadUsageNoticeConfig → the nemoclaw onboard prompt), so a single edit
  corrects every surface.
• Added src/lib/onboard/usage-notice.test.ts, which reads the shipped prompt
  through loadUsageNoticeConfig() and asserts the exact grammatical form and
  the absence of any adjacent duplicated word.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Quality Gates

• Tests added or updated for changed behavior
• Existing tests cover changed behavior — justification:
• Tests not applicable — justification:
• Docs updated for user-facing behavior changes
• Docs not applicable — justification: fixes a typo in a runtime prompt string; no documentation quotes this line.
• Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
• Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: Onboarding-adjacent, but the change is a single grammatical fix to prompt display text; acceptance logic, versioning, and gating are unchanged. Flagging for maintainer confirmation.
• Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Verification

• PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
• Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run check:diff passed when hooks were skipped or unavailable
• Targeted behavior tests pass for the current change set, or tests are marked not applicable above — command/result: npx vitest run --project cli src/lib/onboard/usage-notice.test.ts → 1/1 passed locally and on a fresh clone + npm ci on an Ubuntu x86_64 host (exit 0).
• Applicable broad gate passed — justification: single-string data fix with a focused source-lane test; not a broad runtime/test-harness change.
• Quality Gates section completed with required justifications or waivers
• No secrets, API keys, or credentials committed
• npm run docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: Jason Ma jama@nvidia.com

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes

  • Corrected the license and third-party software acceptance prompt by removing duplicated wording.

• Tests

  • Added coverage to verify the prompt’s grammar and prevent repeated adjacent words.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b76860bc-9c23-4ce8-ab25-17ec2e87e3e2

📥 Commits

Reviewing files that changed from the base of the PR and between d5fa194 and a7c5dd3.

📒 Files selected for processing (2)

• bin/lib/usage-notice.json
• src/lib/onboard/usage-notice.test.ts

---

📝 Walkthrough

Walkthrough

The acceptance prompt removes the duplicated “and” before “third-party software notice.” A Vitest suite verifies the exact corrected prompt and rejects adjacent duplicated words.

Changes

Usage notice prompt

Layer / File(s)	Summary
Correct prompt and verify wording bin/lib/usage-notice.json, src/lib/onboard/usage-notice.test.ts	The prompt text is corrected, with tests covering its exact grammar and adjacent duplicated words.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related issues

• #7302 — Covers the same duplicated “and and” acceptance prompt correction and regression test.

Suggested reviewers: cv

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main fix to the onboarding license acceptance prompt.
Linked Issues check	✅ Passed	The prompt text is corrected to remove the duplicated conjunction and the regression test covers the shipped notice wording.
Out of Scope Changes check	✅ Passed	The changes are limited to the prompt text fix and a focused regression test, with no unrelated scope added.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/7301-acceptance-prompt-doubled-and

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.3.8)

bin/lib/usage-notice.json

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-code-quality]

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in commit a7c5dd3 in the fix/7301-acceptance-... branch remains at 96%, unchanged from commit 65d78ee in the main branch.

TypeScript / code-coverage/cli

The overall coverage in commit a7c5dd3 in the fix/7301-acceptance-... branch remains at 80%, unchanged from commit 65d78ee in the main branch.

Show a code coverage summary of the most impacted files.

File	main 65d78ee	fix/7301-acceptance-... a7c5dd3	+/-
src/lib/onboard...ider-cleanup.ts	100%	88%	-12%
src/lib/inference/local.ts	80%	80%	0%
src/lib/inferen...lama-version.ts	100%	100%	0%
src/lib/sandbox...rce-identity.ts	91%	91%	0%
src/lib/tunnel/services.ts	73%	73%	0%
src/lib/inferen...time-context.ts	92%	93%	+1%
src/lib/state/g...way-registry.ts	94%	95%	+1%

---

_{Updated July 21, 2026 10:06 UTC}

[github-actions]

PR Review Advisor — Informational

Advisor assessment: Informational / high confidence
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions
Status: No actionable findings remain in the canonical review ledger.

Model lanes

• GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
• Nemotron 3 Ultra (second opinion): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
• Model comparison: normalized findings match; normalized E2E selections match; severity counts match.

Nemotron output stays in workflow artifacts and does not change the assessment above.

E2E guidance

Advisory only. E2E / PR Gate selects and runs jobs independently.

Recommended E2E: cloud-onboard

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.