fix: remove redundant receipt PR number

[miyoungc]

Summary

Remove the manually copied pull-request number from documentation writer receipts. GitHub already supplies the PR identity to the workflow and report, while the reviewed head SHA remains the freshness binding.

Changes

• Remove the visible PR-number field from the pull request template and contributor documentation.
• Remove receipt PR-number parsing, comparison, and CSV columns from the receipt report.
• Keep historical receipts with the old field valid and cover that compatibility in the targeted test.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Quality Gates

• Tests added or updated for changed behavior
• Existing tests cover changed behavior — justification:
• Tests not applicable — justification:
• Docs updated for user-facing behavior changes
• Docs not applicable — justification:
• Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
• Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification:
• Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Documentation Writer Review

• Documentation writer subagent reviewed the completed changes
• Result: docs-updated
• Evidence: Reviewed .github/PULL_REQUEST_TEMPLATE.md, AGENTS.md, CONTRIBUTING.md, and docs/resources/engineer-agentic-documentation.mdx; removed PR-number receipt claims and confirmed that GitHub event/report data supplies PR identity.
• Agent: Codex Desktop

DGX Station Hardware Evidence

• Tested on DGX Station
• Tested commit:
• Station profile/scenario:
• Result:
• Supporting evidence:

Verification

• PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
• Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run check:diff passed when hooks were skipped or unavailable
• Targeted behavior tests pass for the current change set, or tests are marked not applicable above — npx vitest run --project integration test/docs-review-receipt.test.ts (14 passed)
• Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result: Not applicable to this focused receipt change.
• Quality Gates section completed with required justifications or waivers
• No secrets, API keys, or credentials committed
• npm run docs builds without warnings (doc changes only) — completed with 0 errors and the existing Fern CLI version warning
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

Additional validation: npm run docs:sync-agent-variants and git diff --check passed.

---

Signed-off-by: Miyoung Choi miyoungc@nvidia.com

Summary by CodeRabbit

• Documentation

  • Updated documentation writer review guidance and receipt contract to identify reviews by the reviewed revision and current instruction version, not pull request number.
  • Clarified how “stale” receipts are detected and when reviews must be rerun.

• Bug Fixes

  • Improved receipt validation, freshness determination, and reporting to rely on revision metadata rather than pull request number matching.
  • Updated generated reports/exports to remove obsolete pull request number fields.

• Tests

  • Adjusted receipt-generation and validation tests, including CSV/report expectations, to match the new receipt semantics.

[coderabbitai]

📝 Walkthrough

Walkthrough

Documentation-review receipts no longer use PR numbers for identity or freshness. Templates and documentation now require reviewed head and AGENTS.md blob SHAs, while validation, reporting, CSV output, and tests use the updated contract.

Changes

Documentation-review receipt identity

Layer / File(s)	Summary
Receipt contract and documentation .github/PULL_REQUEST_TEMPLATE.md, AGENTS.md, CONTRIBUTING.md, docs/resources/engineer-agentic-documentation.mdx	Receipt guidance now uses reviewed head SHA and AGENTS.md blob SHA metadata instead of visible PR-number fields.
Receipt parsing and reporting scripts/docs-review-receipt.mts	Receipt parsing, validation, freshness checks, report records, and CSV output remove PR-number fields and rely on head SHA matching.
Receipt behavior coverage test/docs-review-receipt.test.ts	Fixtures and assertions cover SHA-based freshness, historical receipts, report generation, and removal of PR-number CSV output.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• NVIDIA/NemoClaw#7343: Both changes modify the documentation-review receipt workflow, validator, template, and tests; this PR removes the PR-number validation introduced there.
• NVIDIA/NemoClaw#7400: Both changes modify receipt parsing, eligibility, reporting, templates, and tests in the documentation-review workflow.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: removing the redundant receipt PR number.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/remove-receipt-pr-number

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-code-quality]

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in commit 7596f78 in the codex/remove-receipt... branch remains at 96%, unchanged from commit cce9540 in the main branch.

---

_{Updated July 23, 2026 14:34 UTC}

[github-actions]

🌿 Preview your docs: https://nvidia-preview-pr-7413.docs.buildwithfern.com/nemoclaw

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@test/docs-review-receipt.test.ts`:
- Around line 375-379: Add an assertion in the CSV output test around
csvResult.stdout to verify it does not contain the legacy pr_number_matches
column, alongside the existing receipt_pr_number exclusion. Keep the current
behavioral assertions unchanged.
- Around line 170-177: Update the historical compatibility test around runCheck
to replace the fixture’s PR field with a deliberately mismatched value such as
`#999`, while continuing to assert the receipt is accepted. This ensures legacy
PR-number validation is no longer active rather than merely matching the
fixture’s existing PR number.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d952c4af-c46c-4afe-8803-2a35faf5c533

📥 Commits

Reviewing files that changed from the base of the PR and between d13e34a and 662dfcb.

📒 Files selected for processing (6)

• .github/PULL_REQUEST_TEMPLATE.md
• AGENTS.md
• CONTRIBUTING.md
• docs/resources/engineer-agentic-documentation.mdx
• scripts/docs-review-receipt.mts
• test/docs-review-receipt.test.ts

[github-actions]

PR Review Advisor — Informational

Advisor assessment: Informational / high confidence
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions
Status: No actionable findings remain in the canonical review ledger.

Model lanes

• GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
• Nemotron 3 Ultra (second opinion): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
• Model comparison: normalized findings match; normalized E2E selections differ; severity counts match.

Nemotron output stays in workflow artifacts and does not change the assessment above.

E2E guidance

Advisory only. E2E / PR Gate selects and runs jobs independently.

Recommended E2E: None

1 optional E2E recommendation

• docs-validation

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.