chore(validation): clarify local validation command names - #7633
chore(validation): clarify local validation command names#7633jyaunches wants to merge 10 commits into
Conversation
Signed-off-by: Remy the Refactoror <jmyaunch@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (13)
📝 WalkthroughWalkthroughThis change introduces ChangesValidation command workflow
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit a2c8d78 in the TypeScript / code-coverage/cliThe overall coverage in commit a2c8d78 in the Show a code coverage summary of the most impacted files.
Updated |
|
🌿 Preview your docs: https://nvidia-preview-pr-7633.docs.buildwithfern.com/nemoclaw |
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
Nemotron output stays in workflow artifacts and does not change the assessment above. E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
Signed-off-by: Remy the Refactoror <jmyaunch@gmail.com>
Signed-off-by: Remy the Refactoror <jmyaunch@gmail.com>
Signed-off-by: Remy the Refactoror <jmyaunch@gmail.com>
Signed-off-by: Remy the Refactoror <jmyaunch@gmail.com>
Signed-off-by: Remy the Refactoror <jmyaunch@gmail.com>
Signed-off-by: Remy the Refactoror <jmyaunch@gmail.com>
Signed-off-by: Remy the Refactoror <jmyaunch@gmail.com>
Signed-off-by: Remy the Refactoror <jmyaunch@gmail.com>
Signed-off-by: Remy the Refactoror <jmyaunch@gmail.com>
|
Replaced by #7836 with the same reviewed validation-command change on a fresh branch whose commits are signed and GitHub Verified. The published history on this PR cannot be repaired because force-push is disabled. |
<!-- markdownlint-disable MD041 --> ## Summary Routine pull-request validation now uses the explicit `validate:pr` command, custom repository checks use `checks:repository`, and the broad baseline remains `check`. This PR replaces #7633 with signed, GitHub-verified commits because repository rules forbid repairing its unsigned published history. ## Related Issue Fixes #7550 ## Changes - Added canonical validation commands and non-breaking compatibility aliases. - Updated current hook, lint, contributor, skill, and pull-request-template terminology. - Extended the package-script contract to protect command scopes, file routing, and compatibility aliases. - Lowered the stale `src/lib/core/shell-quote.ts` fan-in budget from 27 to the measured value of 26. Merged PR #7632 reduced the fan-in, and the existing source-architecture check protects this limit. ## Type of Change - [ ] Code change (feature, bug fix, or refactor) - [x] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Quality Gates - [x] Tests added or updated for changed behavior - [ ] Existing tests cover changed behavior — justification: - [ ] Tests not applicable — justification: - [x] Docs updated for user-facing behavior changes - [ ] Docs not applicable — justification: - [ ] Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging) - [ ] Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: - [ ] Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue: ## Documentation Writer Review - [x] Documentation writer subagent reviewed the completed changes - Result: `docs-updated` - Evidence: Contributor validation commands and fallback guidance are documented consistently, including the legacy `npm run checks` scope notice and refreshing `origin/main` before `npm run validate:pr`; focused contract tests, the actual legacy alias, repository checks, normal hooks, and the docs build passed. - Agent: Codex Desktop <!-- docs-review-head-sha: 9303fd6 --> <!-- docs-review-agents-blob-sha: d6ebb79 --> ## DGX Station Hardware Evidence - [ ] Tested on DGX Station - Tested commit: Not applicable - Station profile/scenario: Not applicable - Result: Not applicable - Supporting evidence: Not applicable ## Verification - [x] PR description includes a `Signed-off-by:` line and every commit appears as `Verified` in GitHub - [x] Normal `pre-commit`, `commit-msg`, and `pre-push` hooks passed, or `npm run check:diff` passed when hooks were skipped or unavailable - [x] Targeted behavior tests pass for the current change set, or tests are marked not applicable above — `npm exec -- vitest run test/pr-workflow-contract.test.ts` passed 21 tests; `npm run checks` printed the migration/scope notice and passed; repository checks, source-shape, and test-title validation passed. - [ ] Applicable broad gate passed — `npm test` for broad runtime/test-harness changes; `npm run check` for repo-wide validation/coverage changes — local structural checks and plugin coverage passed; CLI coverage encountered unrelated host-environment and timeout failures, so CI remains authoritative. - [x] Quality Gates section completed with required justifications or waivers - [x] No secrets, API keys, or credentials committed - [ ] `npm run docs` builds without warnings (doc changes only) - [ ] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) --- Signed-off-by: Remy the Refactoror <jmyaunch@gmail.com> Signed-off-by: Julie Yaunches <jyaunches@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added a dedicated pull request validation command. * Added a separate repository checks command and clarified command routing for linting and legacy aliases. * **Documentation** * Updated contributor, maintainer, and verification guidance to use the standardized validation workflow. * Clarified the distinction between pull request validation, repository checks, and broader project checks. * **Tests** * Expanded validation coverage for command routing, compatibility aliases, and repository-check behavior. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Julie Yaunches <jyaunches@nvidia.com> Signed-off-by: Remy the Refactoror <jmyaunch@gmail.com>
Summary
Routine pull-request validation now uses the explicit validate:pr command, custom repository checks use checks:repository, and the broad baseline remains check.
Related Issue
Fixes #7550
Changes
Type of Change
Quality Gates
Documentation Writer Review
docs-updatedDGX Station Hardware Evidence
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run check:diffpassed when hooks were skipped or unavailable — npm run validate:pr reached hook initialization after broker-controlled staging, then external sandbox policy denied cloning shellcheck-py with HTTP 403.npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result:npm run docsbuilds without warnings (doc changes only)Signed-off-by: Remy the Refactoror jmyaunch@gmail.com
Summary by CodeRabbit
Improvements
Documentation
Tests