ci: retire TypeScript migration fallbacks - #7668
Conversation
📝 WalkthroughWalkthroughCoverage CI actions now invoke ChangesCoverage entrypoint migration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Security review — PASSReviewed exact head
Files reviewed: the three coverage composite actions and |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit 5d85df1 in the TypeScript / code-coverage/cliThe overall coverage in commit 5d85df1 in the Show a code coverage summary of the most impacted files.
Updated |
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
Nemotron output stays in workflow artifacts and does not change the assessment above. E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: None This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
|
Security review refresh — PASS. Reviewed exact head 5d85df1. The only delta from the prior nine-category PASS is a regression-test update: the fixture now accepts the canonical .mts entrypoint and rejects a retired .ts-only fixture. No production execution, secrets, permissions, dependencies, input handling, cryptography, configuration, or system controls changed. The focused suite passes 31/31 tests; no security findings. |
Summary
Trusted coverage actions now invoke only the migrated
.mtsentrypoints. Missing entrypoints fail at the canonical path instead of falling back to deleted.tsfiles.Related Issue
Part of #6918
Changes
.tsentrypoint..mtspath..mtsentrypoints and reject a missing canonical file.Type of Change
Quality Gates
5d85df195; the diff narrows trusted execution to fixed.mtspaths and updates only regression tests.Documentation Writer Review
no-docs-needed5d85df195changes only internal CI actions and regression tests. Test titles and CI error text followWRITING.md; no user-facing documentation is affected.DGX Station Hardware Evidence
Verification
Signed-off-by: Carlos Villela cvillela@nvidia.com
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run check:diffpassed when hooks were skipped or unavailablenpx vitest run test/e2e-mock-parity.test.ts test/pr-workflow-contract.test.ts --project integration: 2 files and 31 tests passed. Biome and normal commit hooks passed.npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result:Summary by CodeRabbit
CI and Validation
Tests