fix(onboard): enforce cron inference readiness budget - #8046
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe inference-route deployment probe now uses a two-second curl timeout. A regression test verifies the generated sandbox probe script includes ChangesInference probe timeout
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit 64d5e21 in the TypeScript / code-coverage/cliThe overall coverage in commit 64d5e21 in the Show a code coverage summary of the most impacted files.
Updated |
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
1 additional E2E selection from the second opinionAdvisory only. The primary lane did not select these E2E jobs or targets.
Second-opinion E2E selections are advisory. They do not change the primary assessment or E2E / PR Gate. E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: None 1 optional E2E recommendation
This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
<!-- markdownlint-disable MD041 --> ## Summary Completes the documentation follow-ups identified after the v0.0.100 tag. The durable guides and `docs/changelog/2026-07-31.mdx` now cover final inference-route timing, validation reuse boundaries, and replacement-image cleanup. ## Changes - [#8046](#8046) -> `docs/inference/verify-inference-route.mdx` and `docs/changelog/2026-07-31.mdx`: Documents the 2-second final `inference.local` response budget for OpenClaw and Hermes, including the OpenClaw client-overhead rationale. - [#8044](#8044) -> `docs/inference/understand-provider-validation.mdx`: Documents the exact one-shot Chat Completions validation reuse and forced-revalidation conditions. - [#8039](#8039) and [#8042](#8042) -> `docs/manage-sandboxes/recover-rebuild-sandboxes.mdx` and `docs/changelog/2026-07-31.mdx`: Documents obsolete owned source-image cleanup after durable replacement proof and the `gc` recovery action. - `docs/reference/system-readiness.mdx` and `docs/reference/troubleshooting.mdx`: Applies title case and removes code styling from headings while preserving literal identifiers in prose. ## Type of Change - [ ] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [x] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Quality Gates - [ ] Tests added or updated for changed behavior - [ ] Existing tests cover changed behavior — justification: - [x] Tests not applicable — justification: This documentation-only change does not modify executable behavior. - [x] Docs updated for user-facing behavior changes - [ ] Docs not applicable — justification: - [ ] Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging) - [ ] Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: - [ ] Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue: ## Documentation Writer Review - [x] Documentation writer subagent reviewed the completed changes - Result: `docs-updated` - Evidence: `docs/changelog/2026-07-31.mdx`, `docs/inference/understand-provider-validation.mdx`, `docs/inference/verify-inference-route.mdx`, `docs/manage-sandboxes/recover-rebuild-sandboxes.mdx`, `docs/reference/system-readiness.mdx`, and `docs/reference/troubleshooting.mdx`. The documentation-only diff was reviewed against the writing rules and documentation style. - Agent: Codex Desktop <!-- docs-review-head-sha: 6d2cd17 --> <!-- docs-review-agents-blob-sha: 3dd7c24 --> ## DGX Station Hardware Evidence - [ ] Tested on DGX Station - Tested commit: - Station profile/scenario: - Result: - Supporting evidence: ## Verification - [x] PR description includes a `Signed-off-by:` line and every commit appears as `Verified` in GitHub - [x] Normal `pre-commit`, `commit-msg`, and `pre-push` hooks passed, or `npm run validate:pr` passed after refreshing `origin/main` when hooks were skipped or unavailable - [x] Targeted behavior tests pass for the current change set, or tests are marked not applicable above — command/result or justification: Documentation-only; `npx vitest run test/changelog-docs.test.ts test/agent-variant-docs.test.ts` passed 23 tests. - [ ] Applicable broad gate passed — `npm test` for broad runtime/test-harness changes; `npm run check` for repo-wide validation/coverage changes — command/result: - [x] Quality Gates section completed with required justifications or waivers - [x] No secrets, API keys, or credentials committed - [ ] `npm run docs` builds without warnings (doc changes only) - [x] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) `npm run docs` completed with 0 errors and the existing Fern warning. --- Signed-off-by: Miyoung Choi <miyoungc@nvidia.com> --------- Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Summary
Onboarding now requires
inference.localto respond within two seconds before it reports deployment verification success. The previous five-second probe could pass while OpenClaw cron's 2.5-second provider preflight still timed out immediately after fresh sandbox creation.Changes
/v1/modelsreachability probe from five seconds to two seconds.Type of Change
Quality Gates
Documentation Writer Review
no-docs-neededDGX Station Hardware Evidence
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run validate:prpassed after refreshingorigin/mainwhen hooks were skipped or unavailablenpx vitest run --project cli src/lib/verify-deployment.test.tspassed 41/41; scoped Biome checks andnpm run typecheck:clipassed.npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result:npm run docsbuilds without warnings (doc changes only)Signed-off-by: Senthil Ravichandran senthilr@nvidia.com
Summary by CodeRabbit