feat(runtime): persist host-local inference ownership - #8069
Conversation
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
📝 WalkthroughWalkthroughHost-local inference setup now serializes receipts and stores them with reserved sandbox routes. Registry registration, normalization, loading, and saving validate and preserve canonical receipts. Route fingerprints exclude the receipt. Tests cover transport, preservation, clearing, and malformed values. ChangesHost-local inference receipt transport
Estimated code review effort: 3 (Moderate) | ~25 minutes Suggested labels: Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant HostLocalSetup
participant RouteReservation
participant SandboxRegistry
participant RegistryPersistence
HostLocalSetup->>HostLocalSetup: prepare and serialize host-local route receipt
HostLocalSetup->>RouteReservation: submit route reservation with receipt
RouteReservation->>SandboxRegistry: store receipt on sandbox entry
SandboxRegistry->>RegistryPersistence: validate and serialize registry entry
RegistryPersistence-->>SandboxRegistry: load canonical receipt
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit 990a5f5 in the Show a code coverage summary of the most impacted files.
TypeScript / code-coverage/cliThe overall coverage in commit 990a5f5 in the Show a code coverage summary of the most impacted files.
Updated |
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
2 terminology differences from the second opinionAdvisory only. These are normalized differences from the primary terminology receipt.
6 additional E2E selections from the second opinionAdvisory only. The primary lane did not select these E2E jobs or targets.
Second-opinion terminology and E2E selections are advisory. They do not change the primary assessment or E2E / PR Gate. 2 semantic terminology decisionsTerminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.
E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
ericksoa
changed the title
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
|
@coderabbitai review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/lib/state/registry.ts`:
- Line 234: Update the same-name route reservation handling around
hostLocalInferenceReceipt so an omitted field is not converted to null; only
overwrite the existing receipt when the route provides a string or explicit
null, allowing the existing spread to retain prior values. Add a regression test
covering an existing receipt followed by a reservation without
hostLocalInferenceReceipt, and verify the receipt remains available to
registerCreatedSandbox().
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: a69a50a1-ff56-467c-b4fa-d114f9138c8e
📒 Files selected for processing (13)
src/lib/onboard/sandbox-recreate-transaction.test.tssrc/lib/onboard/sandbox-recreate-transaction.tssrc/lib/onboard/sandbox-registration.test.tssrc/lib/onboard/sandbox-registration.tssrc/lib/onboard/setup-inference.tssrc/lib/state/registry.tssrc/lib/state/registry/host-local-inference.test.tssrc/lib/state/registry/host-local-inference.tssrc/lib/state/registry/persistence.tssrc/lib/state/registry/types.tstest/helpers/host-local-inference-receipt.tstest/onboard-host-local-inference-routing.test.tstest/registry.test.ts
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
cv
left a comment
cv
left a comment
There was a problem hiding this comment.
Reviewed commit 990a5f5634 in bottom-up stack order. This PR depends on #8066, which is not approval-ready. This ownership layer is still a draft and therefore cannot serve as an accepted base for qualification work. Review remains blocked until the parent is reconstructed or repaired, this branch is restacked on the accepted parent commit, and current CI, security, and documentation evidence passes for the resulting commit. No approval is granted for the current branch.
2 participants
Summary
This draft persists canonical provider-neutral host-local inference ownership through onboarding and registry state for OpenClaw, Hermes, and Deep Agents Code. Snapshot and runtime-retirement behavior remains in the following lifecycle slice; production Podman selection stays dormant.
Changes
Quality Gates
Documentation Writer Review
990a5f5634d3df19c7d60b96e0e4b8c438936f20; pending exact-head review.Verification
Exact head:
990a5f5634d3df19c7d60b96e0e4b8c438936f20. Stable base-relative patch ID:e1e6e6798d7ca05c285798918afad402f08c3177.Signed-off-by: Aaron Erickson aerickson@nvidia.com
Summary by CodeRabbit
New Features
Bug Fixes