Skip to content

fix(ci): restore main image and platform gates - #8213

Merged
cv merged 3 commits into
mainfrom
fix/main-ci-contract-drift
Aug 4, 2026
Merged

fix(ci): restore main image and platform gates#8213
cv merged 3 commits into
mainfrom
fix/main-ci-contract-drift

Conversation

@cv

@cv cv commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

Recent main changes left managed-image validation and platform-watch fixtures out of sync with their production contracts. This change restores those gates without weakening package identity, provenance, or forward ownership checks.

Changes

  • Align the Hermes managed-image capability checks with the reviewed aiohttp==3.14.3 update from fix(security): update managed Python dependencies #8203.
  • Validate neutral OpenClaw plugin packages from the installed project directories because OpenClaw 2026.7.1 does not persist plugins.installs metadata.
  • Validate Google Chat with the rest of the installed OpenClaw capability union.
  • Match the BuildKit SLSA base-dependency URI emitted for digest-pinned images while retaining the separate digest check.
  • Mark the Ubuntu container checkout as a Git safe directory and verify HEAD before generating build identity.
  • Make the VM-driver snapshot fixture report the all-interface forward binding required on WSL.
  • Leave the macOS Homebrew failure to existing PR fix(onboard): continue onboarding when Homebrew refuses the pinned OpenShell tap #7739, which has the focused product fix.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Quality Gates

  • Tests added or updated for changed behavior
  • Existing tests cover changed behavior — justification:
  • Tests not applicable — justification:
  • Docs updated for user-facing behavior changes
  • Docs not applicable — justification: This repair changes CI validation and platform test fixtures. It does not change a supported user command, configuration, workflow, or default.
  • Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
  • Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: Pending review of managed-image provenance and package-identity validation.
  • Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Documentation Writer Review

  • Documentation writer subagent reviewed the completed changes
  • Result: blocked
  • Evidence: No documentation paths changed. This host has no independent documentation-writer subagent, so the required final review is pending.
  • Agent: Pi coding agent

DGX Station Hardware Evidence

  • Tested on DGX Station
  • Tested commit:
  • Station profile/scenario:
  • Result:
  • Supporting evidence:

Verification

  • PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
  • Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run validate:pr passed after refreshing origin/main when hooks were skipped or unavailable
  • Targeted behavior tests pass for the current change set, or tests are marked not applicable above — 6 integration files / 60 tests passed; WSL-bound snapshot fixture passed 5/5; review follow-ups passed 33 and 15 focused tests; repository checks, ShellCheck, and normal hooks passed; the repaired verifier accepted the failed main Deep Agents attestation.
  • Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result: GitHub CI will run the broad gate; the redundant local broad run was stopped after focused validation passed.
  • Quality Gates section completed with required justifications or waivers
  • No secrets, API keys, or credentials committed
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Carlos Villela cvillela@nvidia.com

Summary by CodeRabbit

  • Bug Fixes

    • Improved managed image validation for Google Chat and plugin installation consistency.
    • Updated Hermes image checks to use the latest approved aiohttp version.
    • Improved dashboard traffic forwarding behavior in WSL environments.
    • Corrected Docker dependency evidence generation for platform-specific image references.
  • Reliability

    • Added safeguards to ensure builds use the intended source revision.
    • Expanded automated checks for image publication, plugin configuration, and workflow integrity.

@cv cv self-assigned this Aug 4, 2026
@copy-pr-bot

copy-pr-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5c7b1087-5234-43f3-af44-a7c74dacb017

📥 Commits

Reviewing files that changed from the base of the PR and between 0631c76 and 6cd1da3.

📒 Files selected for processing (3)
  • .github/workflows/managed-images.yaml
  • test/managed-image-publication-evidence.test.ts
  • test/managed-image-publication-workflow.test.ts
🚧 Files skipped from review as they are similar to previous changes (3)
  • .github/workflows/managed-images.yaml
  • test/managed-image-publication-evidence.test.ts
  • test/managed-image-publication-workflow.test.ts

📝 Walkthrough

Walkthrough

The PR updates OpenClaw plugin and channel validation, pins Hermes to aiohttp 3.14.3, corrects publication evidence URI construction, hardens the Ubuntu CLI build workflow, and adjusts WSL snapshot gateway fixtures.

Changes

Managed image validation

Layer / File(s) Summary
Plugin and dependency validation
.github/workflows/managed-images.yaml, agents/hermes/Dockerfile, test/hermes-final-image-layout.test.ts, test/managed-image-capability-union.test.ts, test/managed-image-publication-workflow.test.ts
OpenClaw validation discovers installed manifests, checks exact plugin matches, requires Google Chat coverage, and rejects configured plugin installation. Hermes validation and tests require aiohttp 3.14.3.
Publication evidence URI construction
scripts/checks/verify-managed-image-publication-evidence.sh, test/managed-image-publication-evidence.test.ts
Base dependency URIs now separate the repository and digest and use platform-encoded helper output in publication evidence tests.
Workflow build integrity
.github/workflows/platform-vitest-main.yaml, test/platform-vitest-main-workflow.test.ts
The Ubuntu CLI build marks the workspace safe, verifies HEAD against GITHUB_SHA, and then runs the build.

Snapshot gateway fixture

Layer / File(s) Summary
Environment-specific dashboard binding
test/snapshot-gateway-guard.test.ts
The WSL fixture uses 0.0.0.0; other environments use 127.0.0.1 in setup and mocked forwarding output.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested labels: area: ci, bug-fix, platform: container

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the pull request's main changes to restore managed-image and platform CI validation gates.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/main-ci-contract-drift

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

github-code-quality Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in commit 6cd1da3 in the fix/main-ci-contract... branch remains at 96%, unchanged from commit f504948 in the main branch.

TypeScript / code-coverage/cli

The overall coverage in commit 6cd1da3 in the fix/main-ci-contract... branch remains at 81%, unchanged from commit 00c6111 in the main branch.

Show a code coverage summary of the most impacted files.
File main 00c6111 fix/main-ci-contract... 6cd1da3 +/-
src/lib/onboard...mage-runtime.ts 84% 81% -3%
src/lib/onboard...rtup/profile.ts 93% 92% -1%
src/lib/shields/index.ts 69% 69% 0%
src/lib/inferen...ompatibility.ts 94% 94% 0%
src/lib/onboard...mage-runtime.ts 50% 50% 0%
src/lib/onboard...trap/adapter.ts 69% 69% 0%
src/lib/messagi.../persistence.ts 90% 90% 0%
src/lib/onboard...ind-contract.ts 98% 98% 0%
src/lib/sandbox...uild-context.ts 41% 42% +1%
src/lib/domain/.../connect-env.ts 89% 97% +8%

Updated August 04, 2026 10:44 UTC

Comment thread test/managed-image-publication-evidence.test.ts Fixed
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor — No blocking findings reported

Advisor assessment: No blocking advisor findings reported
Next action: Review the warnings below.
Findings: 0 blockers · 1 warning · 0 suggestions

Model lanes

  • GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 1 warning · 0 suggestions
  • Nemotron 3 Ultra (second opinion): Failed after a partial review · low confidence · 0 blockers · 1 warning · 2 suggestions

Second-opinion terminology and E2E selections are advisory. They do not change the primary assessment or E2E / PR Gate.

1 semantic terminology decision

Terminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.

  • established — build identity at test/platform-vitest-main-workflow.test.ts:35: Keep the established term.

E2E guidance

Advisory only. E2E / PR Gate selects and runs jobs independently.

Recommended E2E: cloud-onboard, full-e2e, hermes-e2e, hermes-inference-switch, security-posture

2 optional E2E recommendations
  • snapshot-commands
  • openclaw-plugin-runtime-exdev
1 warning · 0 suggestions

Warnings

Warnings do not block.

PRA-1 Warning — Test rejection of the former SLSA base dependency URI

  • Location: test/managed-image-publication-evidence.test.ts:447
  • Category: tests
  • Problem: The valid evidence fixture now uses the digest-qualified BuildKit base dependency URI, but no test supplies the previous platform-only URI and asserts that the verifier rejects it.
  • Impact: A later verifier change could accept the obsolete URI and weaken the provenance binding without a focused regression failure.
  • Recommendation: Add a fixture case with the former platform-only base dependency URI and assert SLSA binding failure with no evidence output.
  • Verification: Inspect the parameterized rejection cases near line 447 and confirm that one supplies the platform-only URI form.
  • Test coverage: Run the evidence verifier with `slsaDependencyUri` set to the former `pkg:docker/<baseReference>?platform=linux%2Famd64` form; expect a nonzero status, the SLSA binding error, and no evidence file.
  • Evidence: scripts/checks/verify-managed-image-publication-evidence.sh:319-375 requires `?digest=sha256:...&platform=...`. test/managed-image-publication-evidence.test.ts:447-453 tests a digest-qualified URI with a different platform, not the prior platform-only form.

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/managed-images.yaml:
- Around line 588-603: Update the installedPackages discovery around
manifestPath to reject symlinked manifests before parsing: use
fs.lstatSync(manifestPath).isFile() and skip entries that are not regular files,
including symlinks. Preserve the existing name/version matching behavior, and
add a negative test covering a symlinked package.json manifest.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 93f2226f-66fd-474b-b150-92a7b5bf6635

📥 Commits

Reviewing files that changed from the base of the PR and between f504948 and 0631c76.

📒 Files selected for processing (10)
  • .github/workflows/managed-images.yaml
  • .github/workflows/platform-vitest-main.yaml
  • agents/hermes/Dockerfile
  • scripts/checks/verify-managed-image-publication-evidence.sh
  • test/hermes-final-image-layout.test.ts
  • test/managed-image-capability-union.test.ts
  • test/managed-image-publication-evidence.test.ts
  • test/managed-image-publication-workflow.test.ts
  • test/platform-vitest-main-workflow.test.ts
  • test/snapshot-gateway-guard.test.ts

Comment thread .github/workflows/managed-images.yaml
@cv
cv marked this pull request as ready for review August 4, 2026 10:41
@cv
cv merged commit 2fa1d22 into main Aug 4, 2026
105 of 116 checks passed
@cv
cv deleted the fix/main-ci-contract-drift branch August 4, 2026 10:49
@github-actions github-actions Bot added the v0.0.102 Release target label Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v0.0.102 Release target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants