fix(ci): restore main image and platform gates - #8213
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughThe PR updates OpenClaw plugin and channel validation, pins Hermes to ChangesManaged image validation
Snapshot gateway fixture
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit 6cd1da3 in the TypeScript / code-coverage/cliThe overall coverage in commit 6cd1da3 in the Show a code coverage summary of the most impacted files.
Updated |
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
Second-opinion terminology and E2E selections are advisory. They do not change the primary assessment or E2E / PR Gate. 1 semantic terminology decisionTerminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.
E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: 2 optional E2E recommendations
1 warning · 0 suggestionsWarningsWarnings do not block.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/managed-images.yaml:
- Around line 588-603: Update the installedPackages discovery around
manifestPath to reject symlinked manifests before parsing: use
fs.lstatSync(manifestPath).isFile() and skip entries that are not regular files,
including symlinks. Preserve the existing name/version matching behavior, and
add a negative test covering a symlinked package.json manifest.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 93f2226f-66fd-474b-b150-92a7b5bf6635
📒 Files selected for processing (10)
.github/workflows/managed-images.yaml.github/workflows/platform-vitest-main.yamlagents/hermes/Dockerfilescripts/checks/verify-managed-image-publication-evidence.shtest/hermes-final-image-layout.test.tstest/managed-image-capability-union.test.tstest/managed-image-publication-evidence.test.tstest/managed-image-publication-workflow.test.tstest/platform-vitest-main-workflow.test.tstest/snapshot-gateway-guard.test.ts
Summary
Recent main changes left managed-image validation and platform-watch fixtures out of sync with their production contracts. This change restores those gates without weakening package identity, provenance, or forward ownership checks.
Changes
aiohttp==3.14.3update from fix(security): update managed Python dependencies #8203.plugins.installsmetadata.HEADbefore generating build identity.Type of Change
Quality Gates
Documentation Writer Review
blockedDGX Station Hardware Evidence
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run validate:prpassed after refreshingorigin/mainwhen hooks were skipped or unavailablenpm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result: GitHub CI will run the broad gate; the redundant local broad run was stopped after focused validation passed.npm run docsbuilds without warnings (doc changes only)Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit
Bug Fixes
aiohttpversion.Reliability