ci(test): drop stale advisor timing hint - #8327
Conversation
Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR removes the timing hint entry for ChangesCLI timing hints
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit 1bef44d in the TypeScript / code-coverage/cliThe overall coverage in commit 1bef44d in the Show a code coverage summary of the most impacted files.
Updated |
|
Closing in favor of merged #8325. The merged PR removes the same obsolete Current |
PR Review Advisor — InformationalAdvisor assessment: Informational / low confidence Model lanes
Second-opinion terminology and E2E selections are advisory. They do not change the primary assessment or E2E / PR Gate. E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: None This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
Summary
Current
mainsplit and deletedtest/pr-review-advisor.test.ts, but the CLI timing manifest still required that path to exist. CLI shard 8 therefore failed deterministically before unrelated pull requests could complete their merge gates. This removes the obsolete timing entry so the sequencer uses its conservative fallback for the new split files.Changes
ci/cli-test-timing-hints.json.Type of Change
Quality Gates
test/cli-coverage-sequencer.test.tsvalidates that every timing-hint path exists and that the fallback remains conservative.Documentation Writer Review
no-docs-neededDGX Station Hardware Evidence
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run validate:prpassed after refreshingorigin/mainwhen hooks were skipped or unavailablenpx vitest run --project integration test/cli-coverage-sequencer.test.ts: 8/8 passed.npm run docsbuilds without warnings (doc changes only)Signed-off-by: Apurv Kumaria akumaria@nvidia.com
Summary by CodeRabbit