fix(skill): print the Deep Agents install content digest - #8475
fix(skill): print the Deep Agents install content digest#8475laitingsheng wants to merge 5 commits into
Conversation
Signed-off-by: Tinson Lai <tinsonl@nvidia.com>
Signed-off-by: Tinson Lai <tinsonl@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe Deep Agents skill installation command now prints the installed skill’s SHA-256 content digest. A test verifies the output, and the command reference explains how to compare the digest across installations. ChangesSkill install digest
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit 9228ed6 in the Show a code coverage summary of the most impacted files.
TypeScript / code-coverage/cliThe overall coverage in commit 9228ed6 in the Show a code coverage summary of the most impacted files.
Updated |
|
🌿 Preview your docs: https://nvidia-preview-pr-8475.docs.buildwithfern.com/nemoclaw |
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
2 terminology differences from the second opinionAdvisory only. These are normalized differences from the primary terminology receipt.
1 additional E2E selection from the second opinionAdvisory only. The primary lane did not select these E2E jobs or targets.
Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests. 3 semantic terminology decisionsTerminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.
E2E guidanceAdvisory only. A maintainer can dispatch the default E2E suite against this exact revision. Recommended E2E: 1 optional E2E recommendation
This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
|
Sensitive-path maintainer review: PASS — no findings on the current branch revision.
The documentation accurately states what the digest covers and how it can be compared. The PR description now records this receipt. Current CI has no failures; remaining jobs and independent approval are still pending. |
Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
|
Current-branch refresh and review disposition for revision
Fresh CI, automated review, and CodeRabbit are running. The PR remains unmerged until every required gate passes and an independent approval is present. |
Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
|
Maintainer refresh and validation receipt for the current branch revision (
This remains held for independent approval and all protected gates to report green; there is no PR-related local failure to fix. |
apurvvkumaria
left a comment
There was a problem hiding this comment.
Reviewed the current branch revision. The Deep Agents install path now prints only the sandbox-confirmed SHA-256 content digest after a successful fresh installation; failure paths and other agents remain unchanged. The regression test verifies the displayed digest, and the command reference accurately defines what it covers and how to compare it. Focused CLI tests and CLI type checking pass, the documentation and nine-category security receipts are current, all commits are Verified and signed off, and there are no unresolved review threads. Merge remains contingent on the current protected workflows and automated advisor completing successfully.
|
Current branch revision review receipt for 9228ed6:
Current independent approval, every required green gate, and repository mergeability remain required. No waiver or bypass is requested. |
Summary
A Deep Agents skill install computed and confirmed a SHA-256 content digest but never showed it, so the value could not be recorded or compared. The success output now prints that digest alongside the file count and the skill name.
Related Issue
Fixes #8470
Changes
src/lib/actions/sandbox/skill-install.ts: the Deep Agents fresh-install success path printsContent digest (SHA-256): <hex>before the session hint. The value already gated success, so no new plumbing was added.docs/reference/commands.mdx: the Deep Agents block forskill installstates that the confirmed digest is printed and how to use it.src/lib/actions/sandbox/skill-install.test.ts: asserts the exact digest reaches stdout on the fresh shared-install path.Type of Change
Quality Gates
Documentation Writer Review
docs-updateddocs/reference/commands.mdxVerification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run validate:prpassed after refreshingorigin/mainwhen hooks were skipped or unavailablenpx vitest run --project cli src/lib/actions/sandbox/skill-install.test.ts src/lib/skill-install-shared.test.ts(19 passed, 7 skipped);npx vitest run --project integration test/cli/sandbox-skill-install.test.ts(4 passed)npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result:npm run docsbuilds without warnings (doc changes only)npm run docsreports 0 errors and the 2 warnings already present onmain.Signed-off-by: Tinson Lai tinsonl@nvidia.com
Summary by CodeRabbit
New Features
Documentation