Skip to content

fix(skill): print the Deep Agents install content digest - #8475

Open
laitingsheng wants to merge 5 commits into
mainfrom
fix/skill-install-content-digest-output
Open

fix(skill): print the Deep Agents install content digest#8475
laitingsheng wants to merge 5 commits into
mainfrom
fix/skill-install-content-digest-output

Conversation

@laitingsheng

@laitingsheng laitingsheng commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary

A Deep Agents skill install computed and confirmed a SHA-256 content digest but never showed it, so the value could not be recorded or compared. The success output now prints that digest alongside the file count and the skill name.

Related Issue

Fixes #8470

Changes

  • src/lib/actions/sandbox/skill-install.ts: the Deep Agents fresh-install success path prints Content digest (SHA-256): <hex> before the session hint. The value already gated success, so no new plumbing was added.
  • docs/reference/commands.mdx: the Deep Agents block for skill install states that the confirmed digest is printed and how to use it.
  • src/lib/actions/sandbox/skill-install.test.ts: asserts the exact digest reaches stdout on the fresh shared-install path.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Quality Gates

  • Tests added or updated for changed behavior
  • Existing tests cover changed behavior — justification:
  • Tests not applicable — justification:
  • Docs updated for user-facing behavior changes
  • Docs not applicable — justification:
  • Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
  • Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: Maintainer nine-category security review passed with no findings on the current branch revision. The change prints the already-computed, sandbox-confirmed SHA-256 content digest only after the existing install validation succeeds. It does not alter digest computation, trust decisions, authentication, authorization, archive contents, filesystem writes, dependencies, or error handling; the digest is content-attestation evidence rather than credential material.
  • Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Documentation Writer Review

  • Documentation writer subagent reviewed the completed changes
  • Result: docs-updated
  • Evidence: docs/reference/commands.mdx
  • Agent: Codex (independent documentation writer)

Verification

  • PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
  • Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run validate:pr passed after refreshing origin/main when hooks were skipped or unavailable
  • Targeted behavior tests pass for the current change set, or tests are marked not applicable above — command/result or justification: npx vitest run --project cli src/lib/actions/sandbox/skill-install.test.ts src/lib/skill-install-shared.test.ts (19 passed, 7 skipped); npx vitest run --project integration test/cli/sandbox-skill-install.test.ts (4 passed)
  • Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result:
  • Quality Gates section completed with required justifications or waivers
  • No secrets, API keys, or credentials committed
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

npm run docs reports 0 errors and the 2 warnings already present on main.


Signed-off-by: Tinson Lai tinsonl@nvidia.com

Summary by CodeRabbit

  • New Features

    • Successful Deep Agents skill installations now display a SHA-256 content digest.
    • The digest can be compared with future installations to verify installed content consistency.
  • Documentation

    • Updated installation guidance to explain the digest output, calculation, and comparison process.

Signed-off-by: Tinson Lai <tinsonl@nvidia.com>
Signed-off-by: Tinson Lai <tinsonl@nvidia.com>
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7e901906-a1c1-4df3-b9cd-f63e9ee2fa5f

📥 Commits

Reviewing files that changed from the base of the PR and between 46098e3 and 9228ed6.

📒 Files selected for processing (1)
  • docs/reference/commands.mdx
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/reference/commands.mdx

📝 Walkthrough

Walkthrough

The Deep Agents skill installation command now prints the installed skill’s SHA-256 content digest. A test verifies the output, and the command reference explains how to compare the digest across installations.

Changes

Skill install digest

Layer / File(s) Summary
Display and document the installation digest
src/lib/actions/sandbox/skill-install.ts, src/lib/actions/sandbox/skill-install.test.ts, docs/reference/commands.mdx
Successful installation output now includes the SHA-256 content digest. The test checks the digest, and the documentation describes the output and comparison use.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states that the Deep Agents install content digest is now printed.
Linked Issues check ✅ Passed The changes print the existing SHA-256 digest after successful installation, add regression coverage, and document the output as required by issue #8470.
Out of Scope Changes check ✅ Passed The source, test, and documentation changes directly support issue #8470 and introduce no unrelated scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/skill-install-content-digest-output

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

github-code-quality Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in commit 9228ed6 in the fix/skill-install-co... branch remains at 96%, unchanged from commit 2fb89f2 in the main branch.

Show a code coverage summary of the most impacted files.
File main 2fb89f2 fix/skill-install-co... 9228ed6 +/-
nemoclaw/src/bl...est-fixtures.ts 100% 100% 0%
nemoclaw/src/bl...ock-fixtures.ts 0% 97% +97%
nemoclaw/src/co...est-fixtures.ts 0% 100% +100%

TypeScript / code-coverage/cli

The overall coverage in commit 9228ed6 in the fix/skill-install-co... branch remains at 81%, unchanged from commit 0d33997 in the main branch.

Show a code coverage summary of the most impacted files.
File main 0d33997 fix/skill-install-co... 9228ed6 +/-
src/lib/onboard...mo-lifecycle.ts 0% 76% +76%
src/lib/adapter...teway-server.ts 0% 79% +79%
src/lib/voice-g...nclaw-client.ts 0% 83% +83%
src/lib/voice-g...dential-file.ts 0% 88% +88%
src/lib/actions...ateway/serve.ts 0% 91% +91%
src/lib/voice-g...sion-service.ts 0% 93% +93%
src/lib/hermes-...anaged-route.ts 0% 94% +94%
src/lib/inferen...test-support.ts 0% 98% +98%
src/lib/adapter...nd-transport.ts 0% 100% +100%
src/lib/voice-g...ay/contracts.ts 0% 100% +100%

Updated August 07, 2026 00:20 UTC

@laitingsheng laitingsheng added bug-fix PR fixes a bug or regression area: skills Skills, agent behaviors, prompts, or skill packaging integration: dcode LangChain Deep Code integration behavior labels Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor — No blocking findings reported

Advisor assessment: No blocking advisor findings reported
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions

Model lanes

  • GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
  • Nemotron 3 Ultra (second opinion): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
  • Model comparison: normalized findings match; normalized terminology decisions differ; normalized E2E selections differ; severity counts match.
2 terminology differences from the second opinion

Advisory only. These are normalized differences from the primary terminology receipt.

  • content digest at docs/reference/commands.mdx:2671: selected only by the second-opinion lane as established.
  • Content digest (SHA-256) at src/lib/actions/sandbox/skill-install.ts:396: selected only by the second-opinion lane as justified.
1 additional E2E selection from the second opinion

Advisory only. The primary lane did not select these E2E jobs or targets.

  • sandbox-operations: The completed second-opinion lane identified E2E coverage that the primary lane omitted.

Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests.

3 semantic terminology decisions

Terminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.

  • established — content digest at src/lib/actions/sandbox/skill-install.ts:396: Retain `content digest` for this SHA-256 value.
  • justified — sandbox-confirmed at docs/reference/commands.mdx:2671: Retain `sandbox confirmed`; the modifier identifies the verification boundary.
  • established — normalized mode at docs/reference/commands.mdx:2671: Retain `normalized modes` to match the existing archive-attestation term.

E2E guidance

Advisory only. A maintainer can dispatch the default E2E suite against this exact revision.

Recommended E2E: onboard-repair, onboard-resume

1 optional E2E recommendation
  • skill-agent

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.

@apurvvkumaria apurvvkumaria self-assigned this Aug 6, 2026
@apurvvkumaria

Copy link
Copy Markdown
Collaborator

Sensitive-path maintainer review: PASS — no findings on the current branch revision.

  1. Secrets and credentials: PASS; the printed digest is content-attestation evidence, not credential material, and no secret source or value changes.
  2. Input validation: PASS; the existing validated install result remains authoritative and the output uses its confirmed 64-character SHA-256 value.
  3. Authentication and authorization: PASS; no access decision or sandbox authority changes.
  4. Dependencies: PASS; no dependency, image, action, lockfile, or download changes.
  5. Error handling and logging: PASS; the digest is printed only on the existing successful fresh-install path, after validation and installation complete.
  6. Cryptography and data protection: PASS; digest computation and comparison are unchanged, and the output does not weaken verification.
  7. Configuration and security headers: PASS / not applicable; no configuration or network policy changes.
  8. Security testing: PASS; the regression verifies the confirmed digest reaches stdout, while existing shared-install and CLI coverage remains intact.
  9. System security: PASS; no filesystem write, command construction, privilege, process, or runtime isolation change.

The documentation accurately states what the digest covers and how it can be compared. The PR description now records this receipt. Current CI has no failures; remaining jobs and independent approval are still pending.

Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
@apurvvkumaria

Copy link
Copy Markdown
Collaborator

Current-branch refresh and review disposition for revision 1e2e87ac1:

  • The signed current-main refresh preserved the contributor's two original commits and attribution. The effective change remains three files with six added lines.
  • There are no unresolved review threads and no correctness correction was needed.
  • Independent documentation review: PASS, no corrections. The command reference matches the sandbox-confirmed digest algorithm, Deep Agents-only routing is correct, and generated variants plus public CLI/docs parity pass.
  • Sensitive-path re-review: PASS across all nine categories (secrets, validation, authentication/authorization, dependencies, error handling/logging, cryptography/data protection, configuration/network policy, security tests, and system isolation). The change only prints the already-required confirmed digest after a successful install.
  • Local evidence: focused CLI tests 19 passed / 7 skipped; integration tests 4/4 passed; CLI typecheck passed; changed-range hooks passed; docs reported 0 errors and 2 existing warnings; command and flag parity passed for all 84 commands; project membership is exact.
  • GitHub marks the refresh commit Verified, and all commits retain Signed-off-by declarations.

Fresh CI, automated review, and CodeRabbit are running. The PR remains unmerged until every required gate passes and an independent approval is present.

Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
@apurvvkumaria

Copy link
Copy Markdown
Collaborator

Maintainer refresh and validation receipt for the current branch revision (46098e3765):

  • Refreshed from current main with a signed, GitHub-verified merge commit; the contributor-owned change remains the intended 3 files and 6 additions.
  • Focused CLI tests passed (19 passed, 7 skipped), focused integration tests passed (4/4), CLI type-check passed, and the documentation build completed with 0 errors and the 2 existing repository warnings.
  • The documentation-review receipt now names the current branch revision; the reviewed documentation and implementation blobs are unchanged from the prior receipt.
  • Hosted CodeQL jobs are queued, while the protected workflow set has not yet materialized during GitHub Actions degraded availability. I have not requested redundant reruns.

This remains held for independent approval and all protected gates to report green; there is no PR-related local failure to fix.

@apurvvkumaria apurvvkumaria left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the current branch revision. The Deep Agents install path now prints only the sandbox-confirmed SHA-256 content digest after a successful fresh installation; failure paths and other agents remain unchanged. The regression test verifies the displayed digest, and the command reference accurately defines what it covers and how to compare it. Focused CLI tests and CLI type checking pass, the documentation and nine-category security receipts are current, all commits are Verified and signed off, and there are no unresolved review threads. Merge remains contingent on the current protected workflows and automated advisor completing successfully.

@apurvvkumaria

Copy link
Copy Markdown
Collaborator

Current branch revision review receipt for 9228ed6:

  • Documentation writer review: PASS / docs updated. The effective change adds the Deep Agents skill-install content digest and focused coverage. docs/reference/commands.mdx accurately defines the sandbox-confirmed SHA-256 digest, scopes the behavior to the Deep Agents variant, and explains retaining it for later comparison. No further documentation change is needed.
  • Security review: PASS with no findings across all nine categories. The command prints only the already computed SHA-256 digest after a successful fresh install; it does not print skill contents, credentials, paths, or new child-process output. Input handling, authorization, dependencies, error paths, configuration, sandbox boundaries, and runtime policy are unchanged. SHA-256 is the existing standard digest. Focused coverage verifies the successful output, and failure paths remain unchanged.
  • The normal main-branch update preserved the contributor's effective three-file change without a manual conflict resolution. Fresh CI and automated review remain authoritative.

Current independent approval, every required green gate, and repository mergeability remain required. No waiver or bypass is requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: skills Skills, agent behaviors, prompts, or skill packaging bug-fix PR fixes a bug or regression integration: dcode LangChain Deep Code integration behavior release-target v0.0.104 Release target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Deep Agents][Skill Install] Successful install omits SHA-256 content digest from CLI output

2 participants