Skip to content

test(docs): follow moved admin approval guidance - #8593

Merged
cv merged 1 commit into
mainfrom
fix/operator-admin-approval-doc-path
Aug 8, 2026
Merged

test(docs): follow moved admin approval guidance#8593
cv merged 1 commit into
mainfrom
fix/operator-admin-approval-doc-path

Conversation

@ericksoa

@ericksoa ericksoa commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Summary

The v0.0.104 documentation audit moved the auto-pair guidance, but its regression test still read the former file and heading. This change retargets that test to the current documentation location so the CLI test shard passes on main.

Changes

  • Read the operator approval guidance from docs/security/gateway-authentication-controls.mdx.
  • Match the current ## Auto-Pair Client Allowlist heading.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Quality Gates

  • Tests added or updated for changed behavior
  • Existing tests cover changed behavior — justification:
  • Tests not applicable — justification:
  • Docs updated for user-facing behavior changes
  • Docs not applicable — justification: This test-only repair follows documentation already moved on main; it does not change user-facing content.
  • Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
  • Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification:
  • Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Documentation Writer Review

  • Documentation writer subagent reviewed the completed changes
  • Result: no-docs-needed
  • Evidence: This test-only repair retargets the existing documentation regression test to docs/security/gateway-authentication-controls.mdx and the current ## Auto-Pair Client Allowlist heading. It changes no documentation source, command, configuration, workflow, default, error, or support claim.
  • Agent: Codex Desktop

DGX Station Hardware Evidence

  • Tested on DGX Station
  • Tested commit:
  • Station profile/scenario:
  • Result:
  • Supporting evidence:

Verification

  • PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
  • Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run validate:pr passed after refreshing origin/main when hooks were skipped or unavailable
  • Targeted behavior tests pass for the current change set, or tests are marked not applicable above — command/result or justification: npx vitest run --project integration test/repro-5324-operator-admin-approval-docs.test.ts passed (2 tests).
  • Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result:
  • Quality Gates section completed with required justifications or waivers
  • No secrets, API keys, or credentials committed
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Aaron Erickson aerickson@nvidia.com

Summary by CodeRabbit

  • Tests
    • Updated documentation validation to check the gateway authentication controls guide.
    • Continued verifying the operator-admin approval documentation and client allowlist section.

@ericksoa ericksoa self-assigned this Aug 8, 2026
@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2362eca7-71db-4464-9b07-6d698cf3390b

📥 Commits

Reviewing files that changed from the base of the PR and between 1c518f1 and ac4734b.

📒 Files selected for processing (1)
  • test/repro-5324-operator-admin-approval-docs.test.ts

📝 Walkthrough

Walkthrough

The documentation test now reads gateway-authentication-controls.mdx and uses the updated ## Auto-Pair Client Allowlist section anchor.

Changes

Operator-admin approval documentation test

Layer / File(s) Summary
Update documentation test reference
test/repro-5324-operator-admin-approval-docs.test.ts
The test now reads gateway-authentication-controls.mdx and locates the level-two Auto-Pair Client Allowlist section.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: aasthajh

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the test update required by the moved operator admin approval guidance.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/operator-admin-approval-doc-path

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in commit ac4734b in the fix/operator-admin-a... branch remains at 96%, unchanged from commit a506354 in the main branch.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor — No blocking findings reported

Advisor assessment: No blocking advisor findings reported
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions

Model lanes

  • GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
  • Nemotron 3 Ultra (second opinion): Failed

Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests.

E2E guidance

Advisory only. A maintainer can dispatch the default E2E suite against this exact revision.

Recommended E2E: None

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.

@cv
cv merged commit 783a01c into main Aug 8, 2026
63 of 64 checks passed
@cv
cv deleted the fix/operator-admin-approval-doc-path branch August 8, 2026 01:43
@github-actions github-actions Bot added the v0.0.105 Release target label Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v0.0.105 Release target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants