Closed
Conversation
fernandol-nvidia
force-pushed
the
ryali/test
branch
from
baed74e to
cba55a8
Compare
clean up bazel add remote cache remove node deps
Contributor
|
Changes in this PR has been added upstream and this PR can now be closed. |
3 tasks
jiaenren
added a commit
that referenced
this pull request
Mar 25, 2026
Comprehensive one-pass fix for all remaining pylint issues (18 files) plus critical findings from code review. Pylint fixes: - C0103: Revert underscore-prefixed args, use pylint disable instead - C0115: Add docstrings to all 30+ classes (including test classes) - W1405: Normalize to double quotes everywhere, disable where unavoidable - R1732: Wrap bare open() in with statements, disable for Popen - W0611: Remove 6 unused imports across test files - E0110: Disable on intentional abstract class instantiation test - C0207: Use maxsplit=1 in split() Code review critical fixes: - Add missing lcov_path field to CoverageState TypedDict (#1) - Fix {owner}/{repo} placeholders in respond.py gh api calls — now resolved via gh repo view --json nameWithOwner (#3) - Add TODO on min_coverage_delta (declared but not yet implemented) (#8) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jiaenren
added a commit
that referenced
this pull request
Mar 30, 2026
Comprehensive one-pass fix for all remaining pylint issues (18 files) plus critical findings from code review. Pylint fixes: - C0103: Revert underscore-prefixed args, use pylint disable instead - C0115: Add docstrings to all 30+ classes (including test classes) - W1405: Normalize to double quotes everywhere, disable where unavoidable - R1732: Wrap bare open() in with statements, disable for Popen - W0611: Remove 6 unused imports across test files - E0110: Disable on intentional abstract class instantiation test - C0207: Use maxsplit=1 in split() Code review critical fixes: - Add missing lcov_path field to CoverageState TypedDict (#1) - Fix {owner}/{repo} placeholders in respond.py gh api calls — now resolved via gh repo view --json nameWithOwner (#3) - Add TODO on min_coverage_delta (declared but not yet implemented) (#8) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jiaenren
added a commit
that referenced
this pull request
Mar 31, 2026
The LLM guesses dep target names (e.g., //src/cli:access_token) that don't exist — the actual target is //src/cli:cli_lib which bundles all source files. Wrong deps cause every bazel test to fail with "no such target", and the first bad entry poisons the BUILD file for all subsequent targets. Fix: always generate BUILD entries by reading existing deps from sibling test targets in the same BUILD file. Remove BUILD entry generation from the LLM prompt entirely — the LLM should only produce test code. This eliminates the #1 failure mode in CI where all 3 targets fail with identical "no such target" errors across all retry attempts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jiaenren
added a commit
that referenced
this pull request
Mar 31, 2026
Comprehensive one-pass fix for all remaining pylint issues (18 files) plus critical findings from code review. Pylint fixes: - C0103: Revert underscore-prefixed args, use pylint disable instead - C0115: Add docstrings to all 30+ classes (including test classes) - W1405: Normalize to double quotes everywhere, disable where unavoidable - R1732: Wrap bare open() in with statements, disable for Popen - W0611: Remove 6 unused imports across test files - E0110: Disable on intentional abstract class instantiation test - C0207: Use maxsplit=1 in split() Code review critical fixes: - Add missing lcov_path field to CoverageState TypedDict (#1) - Fix {owner}/{repo} placeholders in respond.py gh api calls — now resolved via gh repo view --json nameWithOwner (#3) - Add TODO on min_coverage_delta (declared but not yet implemented) (#8) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jiaenren
added a commit
that referenced
this pull request
Mar 31, 2026
The LLM guesses dep target names (e.g., //src/cli:access_token) that don't exist — the actual target is //src/cli:cli_lib which bundles all source files. Wrong deps cause every bazel test to fail with "no such target", and the first bad entry poisons the BUILD file for all subsequent targets. Fix: always generate BUILD entries by reading existing deps from sibling test targets in the same BUILD file. Remove BUILD entry generation from the LLM prompt entirely — the LLM should only produce test code. This eliminates the #1 failure mode in CI where all 3 targets fail with identical "no such target" errors across all retry attempts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vvnpn-nv
added a commit
that referenced
this pull request
Apr 10, 2026
- Remove unused CONFIGMAP_SYNC_TAGS constant - Remove unused typing imports from configmap_guard - Fix integration test: remove stale managed_configs wrapper (#1) - Fix docstrings: remove "write roles to DB", "authz reads from DB" - Remove dead configmap_state table from postgres.py and schema.sql - Remove stale comment about deleted secret templates in _helpers.tpl - Rename $dc → $cfg in configs.yaml template Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vvnpn-nv
added a commit
that referenced
this pull request
Apr 10, 2026
#1 (CRITICAL): Store watcher on app state to prevent GC from killing the file watcher after configure_app() returns. #9: Activate ConfigMap mode on deferred successful reload. If initial load fails but a later watchdog-triggered reload succeeds, 409 write protection now activates correctly. #3: Move reject_if_configmap_mode() before loops in 6 bulk endpoints (put_pools, put_pod_templates, put_group_templates, put_resource_validations, put_roles, put_backend_tests). Guard doesn't depend on loop variable. #4: Fix Go race on lastModTime in FileRoleStore. Move write inside mu.Lock in Load(), add mu.RLock for read in Start(). #2: Fix import ordering in postgres.py — move configmap_state to first-party import group. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.