Conversation
vvnpn-nv
added a commit
that referenced
this pull request
Apr 10, 2026
#1 (CRITICAL): Store watcher on app state to prevent GC from killing the file watcher after configure_app() returns. #9: Activate ConfigMap mode on deferred successful reload. If initial load fails but a later watchdog-triggered reload succeeds, 409 write protection now activates correctly. #3: Move reject_if_configmap_mode() before loops in 6 bulk endpoints (put_pools, put_pod_templates, put_group_templates, put_resource_validations, put_roles, put_backend_tests). Guard doesn't depend on loop variable. #4: Fix Go race on lastModTime in FileRoleStore. Move write inside mu.Lock in Load(), add mu.RLock for read in Start(). #2: Fix import ordering in postgres.py — move configmap_state to first-party import group. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist