fix(scripts): eliminate xargs subshell dependency in docker-cleanup.sh#1207
Merged
mrunalp merged 1 commit intoNVIDIA:mainfrom May 7, 2026
Merged
Conversation
Replace xargs usage with native docker/podman multi-argument inspect calls. The previous implementation failed because xargs spawns subshells that don't inherit the ce() function from container-engine.sh. Instead of piping container IDs through xargs, collect them into an array and pass them directly to `ce inspect`, which accepts multiple IDs. This eliminates the subshell issue entirely and simplifies the code. Fixes the docker:cleanup mise task that was failing with: xargs: ce: No such file or directory Signed-off-by: Derek Carr <decarr@redhat.com>
derekwaynecarr
requested review from
a team,
maxamillion and
mrunalp
as code owners
TaylorMutch
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace xargs usage with native docker/podman multi-argument inspect calls. The previous implementation failed because xargs spawns subshells that don't inherit the ce() function from container-engine.sh.
Instead of piping container IDs through xargs, collect them into an array and pass them directly to
ce inspect, which accepts multiple IDs. This eliminates the subshell issue entirely and simplifies the code.Fixes the docker:cleanup mise task that was failing with:
xargs: ce: No such file or directory
Related Issue
Changes
Testing
mise run pre-commitpassesChecklist